From 782fea38373d6565b2f27bf64ac8f19cc15ad740 Mon Sep 17 00:00:00 2001 From: godexsoft <385326+godexsoft@users.noreply.github.com> Date: Fri, 18 Apr 2025 09:27:58 +0000 Subject: [PATCH] [CI] clang-tidy auto fixes --- src/util/BlockingCache.hpp | 2 +- tests/unit/rpc/RPCHelpersTests.cpp | 2 +- tests/unit/util/BlockingCacheTests.cpp | 3 --- tests/unit/util/ResponseExpirationCacheTests.cpp | 4 ++-- 4 files changed, 4 insertions(+), 7 deletions(-) diff --git a/src/util/BlockingCache.hpp b/src/util/BlockingCache.hpp index 091be39c..0deccdd8 100644 --- a/src/util/BlockingCache.hpp +++ b/src/util/BlockingCache.hpp @@ -201,7 +201,7 @@ private: boost::system::error_code errorCode; std::optional> result; - boost::signals2::scoped_connection slot = + boost::signals2::scoped_connection const slot = updateFinished_.connect([yield, &timer, &result](std::expected value) { boost::asio::spawn(yield, [&timer, &result, value = std::move(value)](auto&&) { result = std::move(value); diff --git a/tests/unit/rpc/RPCHelpersTests.cpp b/tests/unit/rpc/RPCHelpersTests.cpp index 6d64edd4..2540e2c0 100644 --- a/tests/unit/rpc/RPCHelpersTests.cpp +++ b/tests/unit/rpc/RPCHelpersTests.cpp @@ -1219,7 +1219,7 @@ TEST_P(RPCHelpersLogDurationTest, LogDuration) EXPECT_NE(output.find(tagStr), std::string::npos); if (GetParam().expectDuration) { - std::string durationStr = std::to_string(GetParam().duration.count()) + " milliseconds"; + std::string const durationStr = std::to_string(GetParam().duration.count()) + " milliseconds"; EXPECT_NE(output.find(durationStr), std::string::npos); } diff --git a/tests/unit/util/BlockingCacheTests.cpp b/tests/unit/util/BlockingCacheTests.cpp index 2dcfe5cf..f261d404 100644 --- a/tests/unit/util/BlockingCacheTests.cpp +++ b/tests/unit/util/BlockingCacheTests.cpp @@ -21,8 +21,6 @@ #include "util/BlockingCache.hpp" #include "util/NameGenerator.hpp" -#include -#include #include #include @@ -33,7 +31,6 @@ using testing::Return; using testing::StrictMock; #include -#include #include #include diff --git a/tests/unit/util/ResponseExpirationCacheTests.cpp b/tests/unit/util/ResponseExpirationCacheTests.cpp index ea7af34e..0c02bdc3 100644 --- a/tests/unit/util/ResponseExpirationCacheTests.cpp +++ b/tests/unit/util/ResponseExpirationCacheTests.cpp @@ -50,7 +50,7 @@ struct ResponseExpirationCacheTest : SyncAsioContextTest { TEST_F(ResponseExpirationCacheTest, ShouldCacheDeterminesIfCommandIsCacheable) { - std::unordered_set cmds = {cmd, "account_info"}; + std::unordered_set const cmds = {cmd, "account_info"}; ResponseExpirationCache cache{std::chrono::seconds(10), cmds}; for (auto const& c : cmds) { @@ -259,7 +259,7 @@ TEST_F(ResponseExpirationCacheTest, InvalidateForcesRefresh) ResponseExpirationCache cache{std::chrono::seconds(10), {cmd}}; runSpawn([&](boost::asio::yield_context yield) { - boost::json::object oldObject = {{"some key", "old value"}}; + boost::json::object const oldObject = {{"some key", "old value"}}; EXPECT_CALL(mockUpdater, Call) .WillOnce(Return(ResponseExpirationCache::EntryData{ .lastUpdated = std::chrono::steady_clock::now(),