ARCHIVE/clio
1
0
Fork 0
mirror of https://github.com/XRPLF/clio.git synced 2025-11-30 16:45:51 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: CacheLoader causes crash when no cache is used (#1853)

Browse Source 
If cache is disabled or Clio starts with and empty DB, `loader_` inside
cache is not created. So calling `CacheLoader::stop()` or
`CacheLoader::wait()` was causing crash.
This commit is contained in:
Sergey Kuznetsov
2025-01-28 18:10:19 +00:00
committed by GitHub
parent 540e938223
commit 75354fbecd
2 changed files with 19 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
src/etl/CacheLoader.hpp
View File

@@ -130,7 +130,8 @@ public:
void void
stop() noexcept stop() noexcept
{ {
loader_->stop(); if (loader_ != nullptr)
loader_->stop();
} }
/** /**
@@ -139,7 +140,8 @@ public:
void void
wait() noexcept wait() noexcept
{ {
loader_->wait(); if (loader_ != nullptr)
loader_->wait();
} }
}; };

15
tests/unit/etl/CacheLoaderTests.cpp
View File

@@ -270,3 +270,18 @@ TEST_F(CacheLoaderTest, DisabledCacheLoaderDoesNotLoadCache)
loader.load(kSEQ); loader.load(kSEQ);
} }
TEST_F(CacheLoaderTest, DisabledCacheLoaderCanCallStopAndWait)
{
auto const cfg = getParseCacheConfig(json::parse(R"({"cache": {"load": "none"}})"));
CacheLoader loader{cfg, backend_, cache};
EXPECT_CALL(cache, updateImp).Times(0);
EXPECT_CALL(cache, isFull).WillRepeatedly(Return(false));
EXPECT_CALL(cache, setDisabled).Times(1);
loader.load(kSEQ);
EXPECT_NO_THROW(loader.stop());
EXPECT_NO_THROW(loader.wait());
}