ARCHIVE/clio
1
0
Fork 0
mirror of https://github.com/XRPLF/clio.git synced 2026-08-21 12:40:51 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: Allow deleted libXRPL amendments to still be queried via feature (#3011)

Browse Source
This commit is contained in:
Alex Kremer
2026-03-24 15:34:02 +00:00
committed by GitHub
parent 4e85398aed
commit 7238cc8799
4 changed files with 141 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

31
tests/unit/data/AmendmentCenterTests.cpp
View File

@@ -37,8 +37,9 @@ TEST_F(AmendmentCenterTest, AllAmendmentsFromLibXRPLAreSupported)
<< "XRPL amendment not supported by Clio: " << name;
}
ASSERT_EQ(amendmentCenter.getSupported().size(), ripple::allAmendments().size());
ASSERT_EQ(amendmentCenter.getAll().size(), ripple::allAmendments().size());
// We support at least all the amendments currently exposed by libXRPL
ASSERT_GE(amendmentCenter.getSupported().size(), ripple::allAmendments().size());
ASSERT_GE(amendmentCenter.getAll().size(), ripple::allAmendments().size());
}
TEST_F(AmendmentCenterTest, Accessors)
@@ -147,6 +148,32 @@ TEST_F(AmendmentCenterTest, IsEnabledReturnsVectorOfFalseWhenNoAmendments)
});
}
TEST_F(AmendmentCenterTest, DeletedLibXRPLAmendmentIsNotKnownToLibXRPL)
{
// OwnerPaysFee was removed from libXRPL in 2.6.0; confirm it's not present upstream
EXPECT_FALSE(ripple::allAmendments().contains(std::string{Amendments::OwnerPaysFee}));
}
TEST_F(AmendmentCenterTest, DeletedLibXRPLAmendmentIsPresentInGetAllWithCorrectFlags)
{
auto const& all = amendmentCenter.getAll();
auto const it = std::ranges::find(all, std::string{Amendments::OwnerPaysFee}, &Amendment::name);
ASSERT_NE(
it, all.end()
) << "OwnerPaysFee must be present in getAll() even after libXRPL deleted it";
EXPECT_FALSE(it->isSupportedByXRPL);
EXPECT_TRUE(it->isSupportedByClio);
EXPECT_TRUE(it->isRetired);
}
TEST_F(AmendmentCenterTest, DeletedLibXRPLAmendmentIsSupportedByClio)
{
// Clio still registers OwnerPaysFee so isSupported() and getSupported() must include it
EXPECT_TRUE(amendmentCenter.isSupported(Amendments::OwnerPaysFee));
EXPECT_TRUE(amendmentCenter.getSupported().contains(std::string{Amendments::OwnerPaysFee}));
}
TEST(AmendmentTest, GenerateAmendmentId)
{
// https://xrpl.org/known-amendments.html#disallowincoming refer to the published id