feat: Pass sanitizer as part of conan_profile (#2189)

I noticed we don't need `sanitizer` value anymore, so removed it.

.github/actions/generate/action.yml

@@ -25,15 +25,6 @@ inputs:
     description: Whether Clio is to be statically linked
     required: true
     default: "false"
-  sanitizer:
-    description: Sanitizer to use
-    required: true
-    default: "false"
-    choices:
-      - "false"
-      - "tsan"
-      - "asan"
-      - "ubsan"
   time_trace:
     description: Whether to enable compiler trace reports
     required: true
@@ -74,9 +65,9 @@ runs:
       env:
         BUILD_TYPE: "${{ inputs.build_type }}"
         SANITIZER_OPTION: |-
-          ${{ inputs.sanitizer == 'tsan' && '-Dsan=thread' ||
+          ${{ endsWith(inputs.conan_profile, '.asan') && '-Dsan=address' ||
-              inputs.sanitizer == 'ubsan' && '-Dsan=undefined' ||
+              endsWith(inputs.conan_profile, '.tsan') && '-Dsan=thread' ||
-              inputs.sanitizer == 'asan' && '-Dsan=address' ||
+              endsWith(inputs.conan_profile, '.ubsan') && '-Dsan=undefined' ||
               '' }}
       run: |
         cd build

.github/workflows/build.yml

@@ -76,7 +76,6 @@ jobs:
       static: true
       upload_clio_server: false
       targets: all
-      sanitizer: "false"
       analyze_build_time: false
     secrets:
       CODECOV_TOKEN: ${{ secrets.CODECOV_TOKEN }}

.github/workflows/build_and_test.yml

@@ -57,12 +57,6 @@ on:
         type: string
         default: all
 
-      sanitizer:
-        description: Sanitizer to use
-        required: false
-        type: string
-        default: "false"
-
 jobs:
   build:
     uses: ./.github/workflows/build_impl.yml
@@ -76,7 +70,6 @@ jobs:
       static: ${{ inputs.static }}
       upload_clio_server: ${{ inputs.upload_clio_server }}
       targets: ${{ inputs.targets }}
-      sanitizer: ${{ inputs.sanitizer }}
       analyze_build_time: false
 
   test:
@@ -89,4 +82,3 @@ jobs:
       build_type: ${{ inputs.build_type }}
       run_unit_tests: ${{ inputs.run_unit_tests }}
       run_integration_tests: ${{ inputs.run_integration_tests }}
-      sanitizer: ${{ inputs.sanitizer }}

.github/workflows/build_impl.yml

@@ -48,11 +48,6 @@ on:
         required: true
         type: string
 
-      sanitizer:
-        description: Sanitizer to use
-        required: true
-        type: string
-
       analyze_build_time:
         description: Whether to enable build time analysis
         required: true
@@ -106,7 +101,6 @@ jobs:
           build_type: ${{ inputs.build_type }}
           code_coverage: ${{ inputs.code_coverage }}
           static: ${{ inputs.static }}
-          sanitizer: ${{ inputs.sanitizer }}
           time_trace: ${{ inputs.analyze_build_time }}
 
       - name: Build Clio
@@ -140,11 +134,11 @@ jobs:
           cat /tmp/ccache.stats
 
       - name: Strip unit_tests
-        if: inputs.sanitizer == 'false' && !inputs.code_coverage && !inputs.analyze_build_time
+        if: ${{ !endsWith(inputs.conan_profile, 'san') && !inputs.code_coverage && !inputs.analyze_build_time }}
         run: strip build/clio_tests
 
       - name: Strip integration_tests
-        if: inputs.sanitizer == 'false' && !inputs.code_coverage && !inputs.analyze_build_time
+        if: ${{ !endsWith(inputs.conan_profile, 'san') && !inputs.code_coverage && !inputs.analyze_build_time }}
         run: strip build/clio_integration_tests
 
       - name: Upload clio_server

.github/workflows/nightly.yml

@@ -35,25 +35,21 @@ jobs:
             conan_profile: default_apple_clang
             build_type: Release
             static: false
-            sanitizer: "false"
           - os: heavy
             conan_profile: gcc
             build_type: Release
             static: true
             container: '{ "image": "ghcr.io/xrplf/clio-ci:latest" }'
-            sanitizer: "false"
           - os: heavy
             conan_profile: gcc
             build_type: Debug
             static: true
             container: '{ "image": "ghcr.io/xrplf/clio-ci:latest" }'
-            sanitizer: "false"
           - os: heavy
             conan_profile: gcc.ubsan
             build_type: Release
             static: false
             container: '{ "image": "ghcr.io/xrplf/clio-ci:latest" }'
-            sanitizer: "ubsan"
 
     uses: ./.github/workflows/build_and_test.yml
     with:
@@ -66,7 +62,6 @@ jobs:
       run_integration_tests: true
       upload_clio_server: true
       disable_cache: true
-      sanitizer: ${{ matrix.sanitizer }}
 
   analyze_build_time:
     name: Analyze Build Time
@@ -94,7 +89,6 @@ jobs:
       static: ${{ matrix.static }}
       upload_clio_server: false
       targets: all
-      sanitizer: "false"
       analyze_build_time: true
 
   nightly_release:

.github/workflows/sanitizers.yml

@@ -36,24 +36,17 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        include:
+        conan_profile: ["gcc.asan", "gcc.tsan", "gcc.ubsan"]
-          - sanitizer: tsan
-            compiler: gcc
-          - sanitizer: asan
-            compiler: gcc
-          - sanitizer: ubsan
-            compiler: gcc
 
     uses: ./.github/workflows/build_and_test.yml
     with:
       runs_on: heavy
       container: '{ "image": "ghcr.io/xrplf/clio-ci:latest" }'
       disable_cache: true
-      conan_profile: ${{ matrix.compiler }}.${{ matrix.sanitizer }}
+      conan_profile: ${{ matrix.conan_profile }}
       build_type: Release
       static: false
       run_unit_tests: true
       run_integration_tests: false
       upload_clio_server: false
       targets: clio_tests clio_integration_tests
-      sanitizer: ${{ matrix.sanitizer }}

.github/workflows/test_impl.yml

@@ -33,11 +33,6 @@ on:
         required: true
         type: boolean
 
-      sanitizer:
-        description: Sanitizer to use
-        required: true
-        type: string
-
 jobs:
   unit_tests:
     name: Unit testing ${{ inputs.container != '' && 'in container' || 'natively' }}
@@ -47,8 +42,8 @@ jobs:
     if: inputs.run_unit_tests
 
     env:
-      # TODO: remove when we have fixed all currently existing issues from sanitizers
+      # TODO: remove completely when we have fixed all currently existing issues with sanitizers
-      SANITIZER_IGNORE_ERRORS: ${{ inputs.sanitizer != 'false' && inputs.sanitizer != 'ubsan' }}
+      SANITIZER_IGNORE_ERRORS: ${{ endsWith(inputs.conan_profile, '.asan') || endsWith(inputs.conan_profile, '.tsan') }}
 
     steps:
       - name: Clean workdir