From 6d56ed5ccf7513d53f17f00d24f38ba93ccdf2d9 Mon Sep 17 00:00:00 2001 From: Ayaz Salikhov Date: Thu, 5 Mar 2026 19:01:57 +0000 Subject: [PATCH] chore: Move sharedPtrBackend (#2974) --- src/etl/impl/CacheLoader.hpp | 4 ++-- src/etl/impl/CursorFromAccountProvider.hpp | 4 ++-- src/etl/impl/CursorFromDiffProvider.hpp | 4 ++-- src/etl/impl/CursorFromFixDiffNumProvider.hpp | 4 ++-- src/rpc/RPCEngine.hpp | 4 ++-- src/rpc/handlers/AMMInfo.hpp | 4 ++-- src/rpc/handlers/AccountChannels.hpp | 4 ++-- src/rpc/handlers/AccountCurrencies.hpp | 4 ++-- src/rpc/handlers/AccountInfo.hpp | 4 ++-- src/rpc/handlers/AccountLines.hpp | 4 ++-- src/rpc/handlers/AccountNFTs.hpp | 4 ++-- src/rpc/handlers/AccountObjects.hpp | 4 ++-- src/rpc/handlers/AccountOffers.hpp | 4 ++-- src/rpc/handlers/AccountTx.hpp | 4 ++-- src/rpc/handlers/BookChanges.hpp | 4 ++-- src/rpc/handlers/BookOffers.hpp | 4 ++-- src/rpc/handlers/DepositAuthorized.hpp | 4 ++-- src/rpc/handlers/Feature.hpp | 6 +++--- src/rpc/handlers/GatewayBalances.hpp | 4 ++-- src/rpc/handlers/GetAggregatePrice.hpp | 4 ++-- src/rpc/handlers/Ledger.hpp | 5 +++-- src/rpc/handlers/LedgerData.hpp | 4 ++-- src/rpc/handlers/LedgerEntry.hpp | 4 ++-- src/rpc/handlers/LedgerIndex.hpp | 4 ++-- src/rpc/handlers/LedgerRange.hpp | 4 ++-- src/rpc/handlers/MPTHolders.hpp | 4 ++-- src/rpc/handlers/NFTBuyOffers.hpp | 2 +- src/rpc/handlers/NFTHistory.hpp | 4 ++-- src/rpc/handlers/NFTInfo.hpp | 4 ++-- src/rpc/handlers/NFTOffersCommon.hpp | 4 ++-- src/rpc/handlers/NFTSellOffers.hpp | 2 +- src/rpc/handlers/NFTsByIssuer.hpp | 4 ++-- src/rpc/handlers/NoRippleCheck.hpp | 4 ++-- src/rpc/handlers/ServerInfo.hpp | 16 ++++++++-------- src/rpc/handlers/Subscribe.cpp | 4 ++-- src/rpc/handlers/Subscribe.hpp | 2 +- src/rpc/handlers/TransactionEntry.hpp | 4 ++-- src/rpc/handlers/Tx.hpp | 4 ++-- src/rpc/handlers/VaultInfo.cpp | 2 +- src/rpc/handlers/VaultInfo.hpp | 2 +- 40 files changed, 83 insertions(+), 82 deletions(-) diff --git a/src/etl/impl/CacheLoader.hpp b/src/etl/impl/CacheLoader.hpp index 44b82431d..a2d20e419 100644 --- a/src/etl/impl/CacheLoader.hpp +++ b/src/etl/impl/CacheLoader.hpp @@ -63,7 +63,7 @@ public: template CacheLoaderImpl( CtxType& ctx, - std::shared_ptr const& backend, + std::shared_ptr backend, CacheType& cache, uint32_t const seq, std::size_t const numCacheMarkers, @@ -71,7 +71,7 @@ public: std::vector const& cursors ) : ctx_{ctx} - , backend_{backend} + , backend_{std::move(backend)} , cache_{std::ref(cache)} , queue_{cursors.size()} , remaining_{cursors.size()} diff --git a/src/etl/impl/CursorFromAccountProvider.hpp b/src/etl/impl/CursorFromAccountProvider.hpp index 7dd3ae07a..4c7836fec 100644 --- a/src/etl/impl/CursorFromAccountProvider.hpp +++ b/src/etl/impl/CursorFromAccountProvider.hpp @@ -42,11 +42,11 @@ class CursorFromAccountProvider : public BaseCursorProvider { public: CursorFromAccountProvider( - std::shared_ptr const& backend, + std::shared_ptr backend, size_t numCursors, size_t pageSize ) - : backend_{backend}, numCursors_{numCursors}, pageSize_{pageSize} + : backend_{std::move(backend)}, numCursors_{numCursors}, pageSize_{pageSize} { } diff --git a/src/etl/impl/CursorFromDiffProvider.hpp b/src/etl/impl/CursorFromDiffProvider.hpp index 45eeabed1..e53303d44 100644 --- a/src/etl/impl/CursorFromDiffProvider.hpp +++ b/src/etl/impl/CursorFromDiffProvider.hpp @@ -42,8 +42,8 @@ class CursorFromDiffProvider : public BaseCursorProvider { size_t numCursors_; public: - CursorFromDiffProvider(std::shared_ptr const& backend, size_t numCursors) - : backend_{backend}, numCursors_{numCursors} + CursorFromDiffProvider(std::shared_ptr backend, size_t numCursors) + : backend_{std::move(backend)}, numCursors_{numCursors} { } diff --git a/src/etl/impl/CursorFromFixDiffNumProvider.hpp b/src/etl/impl/CursorFromFixDiffNumProvider.hpp index f31175600..451c5a583 100644 --- a/src/etl/impl/CursorFromFixDiffNumProvider.hpp +++ b/src/etl/impl/CursorFromFixDiffNumProvider.hpp @@ -45,8 +45,8 @@ class CursorFromFixDiffNumProvider : public BaseCursorProvider { size_t numDiffs_; public: - CursorFromFixDiffNumProvider(std::shared_ptr const& backend, size_t numDiffs) - : backend_{backend}, numDiffs_{numDiffs} + CursorFromFixDiffNumProvider(std::shared_ptr backend, size_t numDiffs) + : backend_{std::move(backend)}, numDiffs_{numDiffs} { } diff --git a/src/rpc/RPCEngine.hpp b/src/rpc/RPCEngine.hpp index 95240326a..103dd9782 100644 --- a/src/rpc/RPCEngine.hpp +++ b/src/rpc/RPCEngine.hpp @@ -87,14 +87,14 @@ public: */ RPCEngine( util::config::ClioConfigDefinition const& config, - std::shared_ptr const& backend, + std::shared_ptr backend, std::shared_ptr const& balancer, web::dosguard::DOSGuardInterface const& dosGuard, WorkQueue& workQueue, CountersType& counters, std::shared_ptr const& handlerProvider ) - : backend_{backend} + : backend_{std::move(backend)} , dosGuard_{std::cref(dosGuard)} , workQueue_{std::ref(workQueue)} , counters_{std::ref(counters)} diff --git a/src/rpc/handlers/AMMInfo.hpp b/src/rpc/handlers/AMMInfo.hpp index 28f0524a6..8a9cb9ac1 100644 --- a/src/rpc/handlers/AMMInfo.hpp +++ b/src/rpc/handlers/AMMInfo.hpp @@ -87,10 +87,10 @@ public: * @param amendmentCenter The amendmentCenter to use */ AMMInfoHandler( - std::shared_ptr const& sharedPtrBackend, + std::shared_ptr sharedPtrBackend, std::shared_ptr const& amendmentCenter ) - : sharedPtrBackend_(sharedPtrBackend), amendmentCenter_{amendmentCenter} + : sharedPtrBackend_(std::move(sharedPtrBackend)), amendmentCenter_{amendmentCenter} { } diff --git a/src/rpc/handlers/AccountChannels.hpp b/src/rpc/handlers/AccountChannels.hpp index ff79db721..14bc989e2 100644 --- a/src/rpc/handlers/AccountChannels.hpp +++ b/src/rpc/handlers/AccountChannels.hpp @@ -108,8 +108,8 @@ public: * * @param sharedPtrBackend The backend to use */ - AccountChannelsHandler(std::shared_ptr const& sharedPtrBackend) - : sharedPtrBackend_(sharedPtrBackend) + AccountChannelsHandler(std::shared_ptr sharedPtrBackend) + : sharedPtrBackend_(std::move(sharedPtrBackend)) { } diff --git a/src/rpc/handlers/AccountCurrencies.hpp b/src/rpc/handlers/AccountCurrencies.hpp index 521422603..551456d1c 100644 --- a/src/rpc/handlers/AccountCurrencies.hpp +++ b/src/rpc/handlers/AccountCurrencies.hpp @@ -77,8 +77,8 @@ public: * * @param sharedPtrBackend The backend to use */ - AccountCurrenciesHandler(std::shared_ptr const& sharedPtrBackend) - : sharedPtrBackend_(sharedPtrBackend) + AccountCurrenciesHandler(std::shared_ptr sharedPtrBackend) + : sharedPtrBackend_(std::move(sharedPtrBackend)) { } diff --git a/src/rpc/handlers/AccountInfo.hpp b/src/rpc/handlers/AccountInfo.hpp index d0105dea1..67e164263 100644 --- a/src/rpc/handlers/AccountInfo.hpp +++ b/src/rpc/handlers/AccountInfo.hpp @@ -91,10 +91,10 @@ public: * @param amendmentCenter The amendment center to use */ AccountInfoHandler( - std::shared_ptr const& sharedPtrBackend, + std::shared_ptr sharedPtrBackend, std::shared_ptr const& amendmentCenter ) - : sharedPtrBackend_(sharedPtrBackend), amendmentCenter_{amendmentCenter} + : sharedPtrBackend_(std::move(sharedPtrBackend)), amendmentCenter_{amendmentCenter} { } diff --git a/src/rpc/handlers/AccountLines.hpp b/src/rpc/handlers/AccountLines.hpp index 0c5d846da..64879b156 100644 --- a/src/rpc/handlers/AccountLines.hpp +++ b/src/rpc/handlers/AccountLines.hpp @@ -114,8 +114,8 @@ public: * * @param sharedPtrBackend The backend to use */ - AccountLinesHandler(std::shared_ptr const& sharedPtrBackend) - : sharedPtrBackend_(sharedPtrBackend) + AccountLinesHandler(std::shared_ptr sharedPtrBackend) + : sharedPtrBackend_(std::move(sharedPtrBackend)) { } diff --git a/src/rpc/handlers/AccountNFTs.hpp b/src/rpc/handlers/AccountNFTs.hpp index edea3f0d3..fc379afa9 100644 --- a/src/rpc/handlers/AccountNFTs.hpp +++ b/src/rpc/handlers/AccountNFTs.hpp @@ -83,8 +83,8 @@ public: * * @param sharedPtrBackend The backend to use */ - AccountNFTsHandler(std::shared_ptr const& sharedPtrBackend) - : sharedPtrBackend_(sharedPtrBackend) + AccountNFTsHandler(std::shared_ptr sharedPtrBackend) + : sharedPtrBackend_(std::move(sharedPtrBackend)) { } diff --git a/src/rpc/handlers/AccountObjects.hpp b/src/rpc/handlers/AccountObjects.hpp index 19885221d..aae5d103a 100644 --- a/src/rpc/handlers/AccountObjects.hpp +++ b/src/rpc/handlers/AccountObjects.hpp @@ -90,8 +90,8 @@ public: * * @param sharedPtrBackend The backend to use */ - AccountObjectsHandler(std::shared_ptr const& sharedPtrBackend) - : sharedPtrBackend_(sharedPtrBackend) + AccountObjectsHandler(std::shared_ptr sharedPtrBackend) + : sharedPtrBackend_(std::move(sharedPtrBackend)) { } diff --git a/src/rpc/handlers/AccountOffers.hpp b/src/rpc/handlers/AccountOffers.hpp index ce9595c0b..eb56dd7fe 100644 --- a/src/rpc/handlers/AccountOffers.hpp +++ b/src/rpc/handlers/AccountOffers.hpp @@ -97,8 +97,8 @@ public: * * @param sharedPtrBackend The backend to use */ - AccountOffersHandler(std::shared_ptr const& sharedPtrBackend) - : sharedPtrBackend_(sharedPtrBackend) + AccountOffersHandler(std::shared_ptr sharedPtrBackend) + : sharedPtrBackend_(std::move(sharedPtrBackend)) { } diff --git a/src/rpc/handlers/AccountTx.hpp b/src/rpc/handlers/AccountTx.hpp index 534135b76..c387ac582 100644 --- a/src/rpc/handlers/AccountTx.hpp +++ b/src/rpc/handlers/AccountTx.hpp @@ -115,10 +115,10 @@ public: * @param etl The ETL service to use */ AccountTxHandler( - std::shared_ptr const& sharedPtrBackend, + std::shared_ptr sharedPtrBackend, std::shared_ptr const& etl ) - : sharedPtrBackend_(sharedPtrBackend), etl_{etl} + : sharedPtrBackend_(std::move(sharedPtrBackend)), etl_{etl} { } diff --git a/src/rpc/handlers/BookChanges.hpp b/src/rpc/handlers/BookChanges.hpp index 8125fc4ac..ab7cd6196 100644 --- a/src/rpc/handlers/BookChanges.hpp +++ b/src/rpc/handlers/BookChanges.hpp @@ -75,8 +75,8 @@ public: * * @param sharedPtrBackend The backend to use */ - BookChangesHandler(std::shared_ptr const& sharedPtrBackend) - : sharedPtrBackend_(sharedPtrBackend) + BookChangesHandler(std::shared_ptr sharedPtrBackend) + : sharedPtrBackend_(std::move(sharedPtrBackend)) { } diff --git a/src/rpc/handlers/BookOffers.hpp b/src/rpc/handlers/BookOffers.hpp index 6a79cd848..6346ad93b 100644 --- a/src/rpc/handlers/BookOffers.hpp +++ b/src/rpc/handlers/BookOffers.hpp @@ -98,10 +98,10 @@ public: * @param amendmentCenter The amendmentCenter to use */ BookOffersHandler( - std::shared_ptr const& sharedPtrBackend, + std::shared_ptr sharedPtrBackend, std::shared_ptr const& amendmentCenter ) - : sharedPtrBackend_(sharedPtrBackend), amendmentCenter_{amendmentCenter} + : sharedPtrBackend_(std::move(sharedPtrBackend)), amendmentCenter_{amendmentCenter} { } diff --git a/src/rpc/handlers/DepositAuthorized.hpp b/src/rpc/handlers/DepositAuthorized.hpp index 8c0a740e1..2faa52d92 100644 --- a/src/rpc/handlers/DepositAuthorized.hpp +++ b/src/rpc/handlers/DepositAuthorized.hpp @@ -86,8 +86,8 @@ public: * * @param sharedPtrBackend The backend to use */ - DepositAuthorizedHandler(std::shared_ptr const& sharedPtrBackend) - : sharedPtrBackend_(sharedPtrBackend) + DepositAuthorizedHandler(std::shared_ptr sharedPtrBackend) + : sharedPtrBackend_(std::move(sharedPtrBackend)) { } diff --git a/src/rpc/handlers/Feature.hpp b/src/rpc/handlers/Feature.hpp index 34f1bf685..652e7d5bd 100644 --- a/src/rpc/handlers/Feature.hpp +++ b/src/rpc/handlers/Feature.hpp @@ -84,14 +84,14 @@ public: /** * @brief Construct a new FeatureHandler object * - * @param backend The backend to use + * @param sharedPtrBackend The backend to use * @param amendmentCenter The amendment center to use */ FeatureHandler( - std::shared_ptr const& backend, + std::shared_ptr sharedPtrBackend, std::shared_ptr const& amendmentCenter ) - : sharedPtrBackend_(backend), amendmentCenter_(amendmentCenter) + : sharedPtrBackend_(std::move(sharedPtrBackend)), amendmentCenter_(amendmentCenter) { } diff --git a/src/rpc/handlers/GatewayBalances.hpp b/src/rpc/handlers/GatewayBalances.hpp index 89d4e6f06..1014d39eb 100644 --- a/src/rpc/handlers/GatewayBalances.hpp +++ b/src/rpc/handlers/GatewayBalances.hpp @@ -95,8 +95,8 @@ public: * * @param sharedPtrBackend The backend to use */ - GatewayBalancesHandler(std::shared_ptr const& sharedPtrBackend) - : sharedPtrBackend_(sharedPtrBackend) + GatewayBalancesHandler(std::shared_ptr sharedPtrBackend) + : sharedPtrBackend_(std::move(sharedPtrBackend)) { } diff --git a/src/rpc/handlers/GetAggregatePrice.hpp b/src/rpc/handlers/GetAggregatePrice.hpp index 32b729ac0..7b602a933 100644 --- a/src/rpc/handlers/GetAggregatePrice.hpp +++ b/src/rpc/handlers/GetAggregatePrice.hpp @@ -105,8 +105,8 @@ public: * * @param sharedPtrBackend The backend to use */ - GetAggregatePriceHandler(std::shared_ptr const& sharedPtrBackend) - : sharedPtrBackend_(sharedPtrBackend) + GetAggregatePriceHandler(std::shared_ptr sharedPtrBackend) + : sharedPtrBackend_(std::move(sharedPtrBackend)) { } diff --git a/src/rpc/handlers/Ledger.hpp b/src/rpc/handlers/Ledger.hpp index 75a3ac5b3..d86f5f5a3 100644 --- a/src/rpc/handlers/Ledger.hpp +++ b/src/rpc/handlers/Ledger.hpp @@ -95,10 +95,11 @@ public: * @param amendmentCenter The amendmentCenter to use */ LedgerHandler( - std::shared_ptr const& sharedPtrBackend, + std::shared_ptr sharedPtrBackend, std::shared_ptr amendmentCenter ) - : sharedPtrBackend_(sharedPtrBackend), amendmentCenter_(std::move(amendmentCenter)) + : sharedPtrBackend_(std::move(sharedPtrBackend)) + , amendmentCenter_(std::move(amendmentCenter)) { } diff --git a/src/rpc/handlers/LedgerData.hpp b/src/rpc/handlers/LedgerData.hpp index 88f389648..621089e0f 100644 --- a/src/rpc/handlers/LedgerData.hpp +++ b/src/rpc/handlers/LedgerData.hpp @@ -97,8 +97,8 @@ public: * * @param sharedPtrBackend The backend to use */ - LedgerDataHandler(std::shared_ptr const& sharedPtrBackend) - : sharedPtrBackend_(sharedPtrBackend) + LedgerDataHandler(std::shared_ptr sharedPtrBackend) + : sharedPtrBackend_(std::move(sharedPtrBackend)) { } diff --git a/src/rpc/handlers/LedgerEntry.hpp b/src/rpc/handlers/LedgerEntry.hpp index 33d70a98c..23d174d90 100644 --- a/src/rpc/handlers/LedgerEntry.hpp +++ b/src/rpc/handlers/LedgerEntry.hpp @@ -125,8 +125,8 @@ public: * * @param sharedPtrBackend The backend to use */ - LedgerEntryHandler(std::shared_ptr const& sharedPtrBackend) - : sharedPtrBackend_(sharedPtrBackend) + LedgerEntryHandler(std::shared_ptr sharedPtrBackend) + : sharedPtrBackend_(std::move(sharedPtrBackend)) { } diff --git a/src/rpc/handlers/LedgerIndex.hpp b/src/rpc/handlers/LedgerIndex.hpp index 803aba2df..2e9efc6d5 100644 --- a/src/rpc/handlers/LedgerIndex.hpp +++ b/src/rpc/handlers/LedgerIndex.hpp @@ -67,8 +67,8 @@ public: * * @param sharedPtrBackend The backend to use */ - LedgerIndexHandler(std::shared_ptr const& sharedPtrBackend) - : sharedPtrBackend_(sharedPtrBackend) + LedgerIndexHandler(std::shared_ptr sharedPtrBackend) + : sharedPtrBackend_(std::move(sharedPtrBackend)) { } diff --git a/src/rpc/handlers/LedgerRange.hpp b/src/rpc/handlers/LedgerRange.hpp index 074b6aa91..2c871f9c6 100644 --- a/src/rpc/handlers/LedgerRange.hpp +++ b/src/rpc/handlers/LedgerRange.hpp @@ -55,8 +55,8 @@ public: * * @param sharedPtrBackend The backend to use */ - LedgerRangeHandler(std::shared_ptr const& sharedPtrBackend) - : sharedPtrBackend_(sharedPtrBackend) + LedgerRangeHandler(std::shared_ptr sharedPtrBackend) + : sharedPtrBackend_(std::move(sharedPtrBackend)) { } diff --git a/src/rpc/handlers/MPTHolders.hpp b/src/rpc/handlers/MPTHolders.hpp index d82ac319d..ee957cf7e 100644 --- a/src/rpc/handlers/MPTHolders.hpp +++ b/src/rpc/handlers/MPTHolders.hpp @@ -80,8 +80,8 @@ public: * * @param sharedPtrBackend The backend to use */ - MPTHoldersHandler(std::shared_ptr const& sharedPtrBackend) - : sharedPtrBackend_(sharedPtrBackend) + MPTHoldersHandler(std::shared_ptr sharedPtrBackend) + : sharedPtrBackend_(std::move(sharedPtrBackend)) { } diff --git a/src/rpc/handlers/NFTBuyOffers.hpp b/src/rpc/handlers/NFTBuyOffers.hpp index ed5b96992..26e0e8cb2 100644 --- a/src/rpc/handlers/NFTBuyOffers.hpp +++ b/src/rpc/handlers/NFTBuyOffers.hpp @@ -39,7 +39,7 @@ public: * * @param sharedPtrBackend The backend to use */ - NFTBuyOffersHandler(std::shared_ptr const& sharedPtrBackend) + NFTBuyOffersHandler(std::shared_ptr sharedPtrBackend) : NFTOffersHandlerBase(sharedPtrBackend) { } diff --git a/src/rpc/handlers/NFTHistory.hpp b/src/rpc/handlers/NFTHistory.hpp index 4d91d8d70..ed7e48df1 100644 --- a/src/rpc/handlers/NFTHistory.hpp +++ b/src/rpc/handlers/NFTHistory.hpp @@ -106,8 +106,8 @@ public: * * @param sharedPtrBackend The backend to use */ - NFTHistoryHandler(std::shared_ptr const& sharedPtrBackend) - : sharedPtrBackend_(sharedPtrBackend) + NFTHistoryHandler(std::shared_ptr sharedPtrBackend) + : sharedPtrBackend_(std::move(sharedPtrBackend)) { } diff --git a/src/rpc/handlers/NFTInfo.hpp b/src/rpc/handlers/NFTInfo.hpp index 3e5e1a7fe..f1dde8c48 100644 --- a/src/rpc/handlers/NFTInfo.hpp +++ b/src/rpc/handlers/NFTInfo.hpp @@ -81,8 +81,8 @@ public: * * @param sharedPtrBackend The backend to use */ - NFTInfoHandler(std::shared_ptr const& sharedPtrBackend) - : sharedPtrBackend_(sharedPtrBackend) + NFTInfoHandler(std::shared_ptr sharedPtrBackend) + : sharedPtrBackend_(std::move(sharedPtrBackend)) { } diff --git a/src/rpc/handlers/NFTOffersCommon.hpp b/src/rpc/handlers/NFTOffersCommon.hpp index 9f3bce68e..50f415442 100644 --- a/src/rpc/handlers/NFTOffersCommon.hpp +++ b/src/rpc/handlers/NFTOffersCommon.hpp @@ -84,8 +84,8 @@ public: * * @param sharedPtrBackend The backend to use */ - NFTOffersHandlerBase(std::shared_ptr const& sharedPtrBackend) - : sharedPtrBackend_(sharedPtrBackend) + NFTOffersHandlerBase(std::shared_ptr sharedPtrBackend) + : sharedPtrBackend_(std::move(sharedPtrBackend)) { } diff --git a/src/rpc/handlers/NFTSellOffers.hpp b/src/rpc/handlers/NFTSellOffers.hpp index c325d1e61..7c40aaa8e 100644 --- a/src/rpc/handlers/NFTSellOffers.hpp +++ b/src/rpc/handlers/NFTSellOffers.hpp @@ -39,7 +39,7 @@ public: * * @param sharedPtrBackend The backend to use */ - NFTSellOffersHandler(std::shared_ptr const& sharedPtrBackend) + NFTSellOffersHandler(std::shared_ptr sharedPtrBackend) : NFTOffersHandlerBase(sharedPtrBackend) { } diff --git a/src/rpc/handlers/NFTsByIssuer.hpp b/src/rpc/handlers/NFTsByIssuer.hpp index 053c3850a..52b26d9da 100644 --- a/src/rpc/handlers/NFTsByIssuer.hpp +++ b/src/rpc/handlers/NFTsByIssuer.hpp @@ -81,8 +81,8 @@ public: * * @param sharedPtrBackend The backend to use */ - NFTsByIssuerHandler(std::shared_ptr const& sharedPtrBackend) - : sharedPtrBackend_(sharedPtrBackend) + NFTsByIssuerHandler(std::shared_ptr sharedPtrBackend) + : sharedPtrBackend_(std::move(sharedPtrBackend)) { } diff --git a/src/rpc/handlers/NoRippleCheck.hpp b/src/rpc/handlers/NoRippleCheck.hpp index 1030a0263..def23f58c 100644 --- a/src/rpc/handlers/NoRippleCheck.hpp +++ b/src/rpc/handlers/NoRippleCheck.hpp @@ -90,8 +90,8 @@ public: * * @param sharedPtrBackend The backend to use */ - NoRippleCheckHandler(std::shared_ptr const& sharedPtrBackend) - : sharedPtrBackend_(sharedPtrBackend) + NoRippleCheckHandler(std::shared_ptr sharedPtrBackend) + : sharedPtrBackend_(std::move(sharedPtrBackend)) { } diff --git a/src/rpc/handlers/ServerInfo.hpp b/src/rpc/handlers/ServerInfo.hpp index 39dace5f0..9cea48528 100644 --- a/src/rpc/handlers/ServerInfo.hpp +++ b/src/rpc/handlers/ServerInfo.hpp @@ -152,16 +152,16 @@ public: * @param counters The counters to use */ BaseServerInfoHandler( - std::shared_ptr const& backend, - std::shared_ptr const& subscriptions, - std::shared_ptr const& balancer, - std::shared_ptr const& etl, + std::shared_ptr backend, + std::shared_ptr subscriptions, + std::shared_ptr balancer, + std::shared_ptr etl, CountersType const& counters ) - : backend_(backend) - , subscriptions_(subscriptions) - , balancer_(balancer) - , etl_(etl) + : backend_(std::move(backend)) + , subscriptions_(std::move(subscriptions)) + , balancer_(std::move(balancer)) + , etl_(std::move(etl)) , counters_(std::cref(counters)) { } diff --git a/src/rpc/handlers/Subscribe.cpp b/src/rpc/handlers/Subscribe.cpp index dda879d3f..4c63c2404 100644 --- a/src/rpc/handlers/Subscribe.cpp +++ b/src/rpc/handlers/Subscribe.cpp @@ -54,11 +54,11 @@ namespace rpc { SubscribeHandler::SubscribeHandler( - std::shared_ptr const& sharedPtrBackend, + std::shared_ptr sharedPtrBackend, std::shared_ptr const& amendmentCenter, std::shared_ptr const& subscriptions ) - : sharedPtrBackend_(sharedPtrBackend) + : sharedPtrBackend_(std::move(sharedPtrBackend)) , amendmentCenter_(amendmentCenter) , subscriptions_(subscriptions) { diff --git a/src/rpc/handlers/Subscribe.hpp b/src/rpc/handlers/Subscribe.hpp index c2aeaad69..2695b6312 100644 --- a/src/rpc/handlers/Subscribe.hpp +++ b/src/rpc/handlers/Subscribe.hpp @@ -105,7 +105,7 @@ public: * @param subscriptions The subscription manager to use */ SubscribeHandler( - std::shared_ptr const& sharedPtrBackend, + std::shared_ptr sharedPtrBackend, std::shared_ptr const& amendmentCenter, std::shared_ptr const& subscriptions ); diff --git a/src/rpc/handlers/TransactionEntry.hpp b/src/rpc/handlers/TransactionEntry.hpp index cf6e812cc..1b096eb92 100644 --- a/src/rpc/handlers/TransactionEntry.hpp +++ b/src/rpc/handlers/TransactionEntry.hpp @@ -79,8 +79,8 @@ public: * * @param sharedPtrBackend The backend to use */ - TransactionEntryHandler(std::shared_ptr const& sharedPtrBackend) - : sharedPtrBackend_(sharedPtrBackend) + TransactionEntryHandler(std::shared_ptr sharedPtrBackend) + : sharedPtrBackend_(std::move(sharedPtrBackend)) { } diff --git a/src/rpc/handlers/Tx.hpp b/src/rpc/handlers/Tx.hpp index 06bccb3c1..fe9332297 100644 --- a/src/rpc/handlers/Tx.hpp +++ b/src/rpc/handlers/Tx.hpp @@ -107,10 +107,10 @@ public: * @param etl The ETL service to use */ TxHandler( - std::shared_ptr const& sharedPtrBackend, + std::shared_ptr sharedPtrBackend, std::shared_ptr const& etl ) - : sharedPtrBackend_(sharedPtrBackend), etl_(etl) + : sharedPtrBackend_(std::move(sharedPtrBackend)), etl_(etl) { } diff --git a/src/rpc/handlers/VaultInfo.cpp b/src/rpc/handlers/VaultInfo.cpp index 74a2d15d3..91ecf9e90 100644 --- a/src/rpc/handlers/VaultInfo.cpp +++ b/src/rpc/handlers/VaultInfo.cpp @@ -70,7 +70,7 @@ validate(VaultInfoHandler::Input const& input) } // namespace -VaultInfoHandler::VaultInfoHandler(std::shared_ptr const& sharedPtrBackend) +VaultInfoHandler::VaultInfoHandler(std::shared_ptr sharedPtrBackend) : sharedPtrBackend_{sharedPtrBackend} { } diff --git a/src/rpc/handlers/VaultInfo.hpp b/src/rpc/handlers/VaultInfo.hpp index 2af07dbcf..e1446cfb0 100644 --- a/src/rpc/handlers/VaultInfo.hpp +++ b/src/rpc/handlers/VaultInfo.hpp @@ -52,7 +52,7 @@ public: * * @param sharedPtrBackend The backend to use */ - VaultInfoHandler(std::shared_ptr const& sharedPtrBackend); + VaultInfoHandler(std::shared_ptr sharedPtrBackend); /** * @brief A struct to hold the input data for the command