From 67c989081d48ee86e57ae43f6f9ba6660c55c6ef Mon Sep 17 00:00:00 2001 From: cyan317 <120398799+cindyyan317@users.noreply.github.com> Date: Mon, 3 Feb 2025 12:00:59 +0000 Subject: [PATCH] fix clang-tidy issues (#1871) --- tests/common/util/TestObject.cpp | 2 +- tests/unit/etl/NFTHelpersTests.cpp | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/common/util/TestObject.cpp b/tests/common/util/TestObject.cpp index fa2b3adb..55e9f844 100644 --- a/tests/common/util/TestObject.cpp +++ b/tests/common/util/TestObject.cpp @@ -1027,7 +1027,7 @@ createAcceptNftSellerOfferTxWithMetadata( // offer owner is not the nft's new owner for seller offer, we need to create other nodes for processing new owner finalFields.setAccountID(ripple::sfOwner, account.value()); - node.emplace_back(std::move(finalFields)); + node.emplace_back(finalFields); node.setFieldH256(ripple::sfLedgerIndex, ripple::uint256{offerId}); metaArray.push_back(node); diff --git a/tests/unit/etl/NFTHelpersTests.cpp b/tests/unit/etl/NFTHelpersTests.cpp index e048b8df..01e24933 100644 --- a/tests/unit/etl/NFTHelpersTests.cpp +++ b/tests/unit/etl/NFTHelpersTests.cpp @@ -479,7 +479,7 @@ TEST_F(NFTHelpersTest, NFTDataFromLedgerObject) auto const nftDatas = etl::getNFTDataFromObj( kSEQ, - std::string(static_cast(static_cast(account.data())), ripple::AccountID::size()), + std::string(reinterpret_cast(account.data()), ripple::AccountID::size()), std::string(static_cast(serializerNftPage.getDataPtr()), serializerNftPage.getDataLength()) );