perf: Pass const reference Input into handlers (#2409)

Fix https://github.com/XRPLF/clio/issues/2265

---------

Co-authored-by: Sergey Kuznetsov <skuznetsov@ripple.com>

src/rpc/common/Concepts.hpp

@@ -69,9 +69,10 @@ concept SomeProcessor = (SomeRequirement<T> or SomeModifier<T>);
  * @brief A process function that expects both some Input and a Context.
  */
 template <typename T>
-concept SomeContextProcessWithInput = requires(T a, typename T::Input in, typename T::Output out, Context const& ctx) {
+concept SomeContextProcessWithInput =
-    { a.process(in, ctx) } -> std::same_as<HandlerReturnType<decltype(out)>>;
+    requires(T a, typename T::Input const& in, typename T::Output out, Context const& ctx) {
-};
+        { a.process(in, ctx) } -> std::same_as<HandlerReturnType<decltype(out)>>;
+    };
 
 /**
  * @brief A process function that expects no Input but does take a Context.

src/rpc/handlers/AMMInfo.cpp

@@ -77,7 +77,7 @@ toIso8601(ripple::NetClock::time_point tp)
 namespace rpc {
 
 AMMInfoHandler::Result
-AMMInfoHandler::process(AMMInfoHandler::Input input, Context const& ctx) const
+AMMInfoHandler::process(AMMInfoHandler::Input const& input, Context const& ctx) const
 {
     using namespace ripple;
 

src/rpc/handlers/AMMInfo.hpp

@@ -111,7 +111,7 @@ public:
      * @return The result of the operation
      */
     Result
-    process(Input input, Context const& ctx) const;
+    process(Input const& input, Context const& ctx) const;
 
 private:
     /**

src/rpc/handlers/AccountChannels.cpp

@@ -81,7 +81,7 @@ AccountChannelsHandler::addChannel(std::vector<ChannelResponse>& jsonChannels, r
 }
 
 AccountChannelsHandler::Result
-AccountChannelsHandler::process(AccountChannelsHandler::Input input, Context const& ctx) const
+AccountChannelsHandler::process(AccountChannelsHandler::Input const& input, Context const& ctx) const
 {
     auto const range = sharedPtrBackend_->fetchLedgerRange();
     ASSERT(range.has_value(), "AccountChannel's ledger range must be available");

src/rpc/handlers/AccountChannels.hpp

@@ -145,7 +145,7 @@ public:
      * @return The result of the operation
      */
     Result
-    process(Input input, Context const& ctx) const;
+    process(Input const& input, Context const& ctx) const;
 
 private:
     static void

src/rpc/handlers/AccountCurrencies.cpp

@@ -43,7 +43,7 @@
 
 namespace rpc {
 AccountCurrenciesHandler::Result
-AccountCurrenciesHandler::process(AccountCurrenciesHandler::Input input, Context const& ctx) const
+AccountCurrenciesHandler::process(AccountCurrenciesHandler::Input const& input, Context const& ctx) const
 {
     auto const range = sharedPtrBackend_->fetchLedgerRange();
     ASSERT(range.has_value(), "AccountCurrencies' ledger range must be available");

src/rpc/handlers/AccountCurrencies.hpp

@@ -110,7 +110,7 @@ public:
      * @return The result of the operation
      */
     Result
-    process(Input input, Context const& ctx) const;
+    process(Input const& input, Context const& ctx) const;
 
 private:
     /**

src/rpc/handlers/AccountInfo.cpp

@@ -50,7 +50,7 @@
 
 namespace rpc {
 AccountInfoHandler::Result
-AccountInfoHandler::process(AccountInfoHandler::Input input, Context const& ctx) const
+AccountInfoHandler::process(AccountInfoHandler::Input const& input, Context const& ctx) const
 {
     using namespace data;
 

src/rpc/handlers/AccountInfo.hpp

@@ -159,7 +159,7 @@ public:
      * @return The result of the operation
      */
     Result
-    process(Input input, Context const& ctx) const;
+    process(Input const& input, Context const& ctx) const;
 
 private:
     /**

src/rpc/handlers/AccountLines.cpp

@@ -130,7 +130,7 @@ AccountLinesHandler::addLine(
 }
 
 AccountLinesHandler::Result
-AccountLinesHandler::process(AccountLinesHandler::Input input, Context const& ctx) const
+AccountLinesHandler::process(AccountLinesHandler::Input const& input, Context const& ctx) const
 {
     auto const range = sharedPtrBackend_->fetchLedgerRange();
     ASSERT(range.has_value(), "AccountLines' ledger range must be available");

src/rpc/handlers/AccountLines.hpp

@@ -160,7 +160,7 @@ public:
      * @return The result of the operation
      */
     Result
-    process(Input input, Context const& ctx) const;
+    process(Input const& input, Context const& ctx) const;
 
 private:
     static void

src/rpc/handlers/AccountNFTs.cpp

@@ -49,7 +49,7 @@
 namespace rpc {
 
 AccountNFTsHandler::Result
-AccountNFTsHandler::process(AccountNFTsHandler::Input input, Context const& ctx) const
+AccountNFTsHandler::process(AccountNFTsHandler::Input const& input, Context const& ctx) const
 {
     auto const range = sharedPtrBackend_->fetchLedgerRange();
     ASSERT(range.has_value(), "AccountNFT's ledger range must be available");

src/rpc/handlers/AccountNFTs.hpp

@@ -118,7 +118,7 @@ public:
      * @return The result of the operation
      */
     Result
-    process(Input input, Context const& ctx) const;
+    process(Input const& input, Context const& ctx) const;
 
 private:
     /**

src/rpc/handlers/AccountObjects.cpp

@@ -49,7 +49,7 @@
 namespace rpc {
 
 AccountObjectsHandler::Result
-AccountObjectsHandler::process(AccountObjectsHandler::Input input, Context const& ctx) const
+AccountObjectsHandler::process(AccountObjectsHandler::Input const& input, Context const& ctx) const
 {
     auto const range = sharedPtrBackend_->fetchLedgerRange();
     ASSERT(range.has_value(), "AccountObject's ledger range must be available");

src/rpc/handlers/AccountObjects.hpp

@@ -134,7 +134,7 @@ public:
      * @return The result of the operation
      */
     Result
-    process(Input input, Context const& ctx) const;
+    process(Input const& input, Context const& ctx) const;
 
 private:
     /**

src/rpc/handlers/AccountOffers.cpp

@@ -65,7 +65,7 @@ AccountOffersHandler::addOffer(std::vector<Offer>& offers, ripple::SLE const& of
 };
 
 AccountOffersHandler::Result
-AccountOffersHandler::process(AccountOffersHandler::Input input, Context const& ctx) const
+AccountOffersHandler::process(AccountOffersHandler::Input const& input, Context const& ctx) const
 {
     auto const range = sharedPtrBackend_->fetchLedgerRange();
     ASSERT(range.has_value(), "AccountOffer's ledger range must be available");

src/rpc/handlers/AccountOffers.hpp

@@ -135,7 +135,7 @@ public:
      * @return The result of the operation
      */
     Result
-    process(Input input, Context const& ctx) const;
+    process(Input const& input, Context const& ctx) const;
 
 private:
     static void

src/rpc/handlers/AccountTx.cpp

@@ -52,7 +52,7 @@ namespace rpc {
 // TODO: this is currently very similar to nft_history but its own copy for time
 // being. we should aim to reuse common logic in some way in the future.
 AccountTxHandler::Result
-AccountTxHandler::process(AccountTxHandler::Input input, Context const& ctx) const
+AccountTxHandler::process(AccountTxHandler::Input const& input, Context const& ctx) const
 {
     auto const range = sharedPtrBackend_->fetchLedgerRange();
     ASSERT(range.has_value(), "AccountTX's ledger range must be available");

src/rpc/handlers/AccountTx.hpp

@@ -178,7 +178,7 @@ public:
      * @return The result of the operation
      */
     Result
-    process(Input input, Context const& ctx) const;
+    process(Input const& input, Context const& ctx) const;
 
 private:
     /**

src/rpc/handlers/BookChanges.cpp

@@ -41,7 +41,7 @@
 namespace rpc {
 
 BookChangesHandler::Result
-BookChangesHandler::process(BookChangesHandler::Input input, Context const& ctx) const
+BookChangesHandler::process(BookChangesHandler::Input const& input, Context const& ctx) const
 {
     auto const range = sharedPtrBackend_->fetchLedgerRange();
     ASSERT(range.has_value(), "BookChanges' ledger range must be available");

src/rpc/handlers/BookChanges.hpp

@@ -104,7 +104,7 @@ public:
      * @return The result of the operation
      */
     Result
-    process(Input input, Context const& ctx) const;
+    process(Input const& input, Context const& ctx) const;
 
 private:
     /**

src/rpc/handlers/BookOffers.cpp

@@ -42,7 +42,7 @@
 namespace rpc {
 
 BookOffersHandler::Result
-BookOffersHandler::process(Input input, Context const& ctx) const
+BookOffersHandler::process(Input const& input, Context const& ctx) const
 {
     auto bookMaybe = parseBook(input.paysCurrency, input.paysID, input.getsCurrency, input.getsID, input.domain);
     if (!bookMaybe.has_value())

src/rpc/handlers/BookOffers.hpp

@@ -175,7 +175,7 @@ public:
      * @return The result of the operation
      */
     Result
-    process(Input input, Context const& ctx) const;
+    process(Input const& input, Context const& ctx) const;
 
 private:
     /**

src/rpc/handlers/DepositAuthorized.cpp

@@ -49,7 +49,7 @@
 namespace rpc {
 
 DepositAuthorizedHandler::Result
-DepositAuthorizedHandler::process(DepositAuthorizedHandler::Input input, Context const& ctx) const
+DepositAuthorizedHandler::process(DepositAuthorizedHandler::Input const& input, Context const& ctx) const
 {
     auto const range = sharedPtrBackend_->fetchLedgerRange();
     ASSERT(range.has_value(), "DepositAuthorized ledger range must be available");

src/rpc/handlers/DepositAuthorized.hpp

@@ -118,7 +118,7 @@ public:
      * @return The result of the operation
      */
     Result
-    process(Input input, Context const& ctx) const;
+    process(Input const& input, Context const& ctx) const;
 
 private:
     /**

src/rpc/handlers/Feature.cpp

@@ -50,7 +50,7 @@
 namespace rpc {
 
 FeatureHandler::Result
-FeatureHandler::process(FeatureHandler::Input input, Context const& ctx) const
+FeatureHandler::process(FeatureHandler::Input const& input, Context const& ctx) const
 {
     namespace vs = std::views;
     namespace rg = std::ranges;

src/rpc/handlers/Feature.hpp

@@ -111,7 +111,7 @@ public:
      * @return The result of the operation
      */
     Result
-    process(Input input, Context const& ctx) const;  // NOLINT(readability-convert-member-functions-to-static)
+    process(Input const& input, Context const& ctx) const;  // NOLINT(readability-convert-member-functions-to-static)
 
 private:
     /**

src/rpc/handlers/GatewayBalances.cpp

@@ -55,7 +55,7 @@
 namespace rpc {
 
 GatewayBalancesHandler::Result
-GatewayBalancesHandler::process(GatewayBalancesHandler::Input input, Context const& ctx) const
+GatewayBalancesHandler::process(GatewayBalancesHandler::Input const& input, Context const& ctx) const
 {
     // check ledger
     auto const range = sharedPtrBackend_->fetchLedgerRange();

src/rpc/handlers/GatewayBalances.hpp

@@ -164,7 +164,7 @@ public:
      * @return The result of the operation
      */
     Result
-    process(Input input, Context const& ctx) const;
+    process(Input const& input, Context const& ctx) const;
 
 private:
     /**

src/rpc/handlers/GetAggregatePrice.cpp

@@ -58,7 +58,7 @@
 namespace rpc {
 
 GetAggregatePriceHandler::Result
-GetAggregatePriceHandler::process(GetAggregatePriceHandler::Input input, Context const& ctx) const
+GetAggregatePriceHandler::process(GetAggregatePriceHandler::Input const& input, Context const& ctx) const
 {
     auto const range = sharedPtrBackend_->fetchLedgerRange();
     ASSERT(range.has_value(), "GetAggregatePrice's ledger range must be available");

src/rpc/handlers/GetAggregatePrice.hpp

@@ -198,7 +198,7 @@ public:
      * @return The result of the operation
      */
     Result
-    process(Input input, Context const& ctx) const;
+    process(Input const& input, Context const& ctx) const;
 
 private:
     /**

src/rpc/handlers/Ledger.cpp

@@ -48,7 +48,7 @@
 
 namespace rpc {
 LedgerHandler::Result
-LedgerHandler::process(LedgerHandler::Input input, Context const& ctx) const
+LedgerHandler::process(LedgerHandler::Input const& input, Context const& ctx) const
 {
     auto const range = sharedPtrBackend_->fetchLedgerRange();
     ASSERT(range.has_value(), "LedgerHandler's ledger range must be available");

src/rpc/handlers/Ledger.hpp

@@ -139,7 +139,7 @@ public:
      * @return The result of the operation
      */
     Result
-    process(Input input, Context const& ctx) const;
+    process(Input const& input, Context const& ctx) const;
 
 private:
     /**

src/rpc/handlers/LedgerData.cpp

@@ -51,7 +51,7 @@
 namespace rpc {
 
 LedgerDataHandler::Result
-LedgerDataHandler::process(Input input, Context const& ctx) const
+LedgerDataHandler::process(Input const& input, Context const& ctx) const
 {
     // marker must be int if outOfOrder is true
     if (input.outOfOrder && input.marker)

src/rpc/handlers/LedgerData.hpp

@@ -141,7 +141,7 @@ public:
      * @return The result of the operation
      */
     Result
-    process(Input input, Context const& ctx) const;
+    process(Input const& input, Context const& ctx) const;
 
 private:
     /**

src/rpc/handlers/LedgerEntry.cpp

@@ -58,7 +58,7 @@
 namespace rpc {
 
 LedgerEntryHandler::Result
-LedgerEntryHandler::process(LedgerEntryHandler::Input input, Context const& ctx) const
+LedgerEntryHandler::process(LedgerEntryHandler::Input const& input, Context const& ctx) const
 {
     ripple::uint256 key;
 

src/rpc/handlers/LedgerEntry.hpp

@@ -443,7 +443,7 @@ public:
      * @return The result of the operation
      */
     Result
-    process(Input input, Context const& ctx) const;
+    process(Input const& input, Context const& ctx) const;
 
 private:
     // dir_root and owner can not be both empty or filled at the same time

src/rpc/handlers/LedgerIndex.cpp

@@ -40,7 +40,7 @@
 namespace rpc {
 
 LedgerIndexHandler::Result
-LedgerIndexHandler::process(LedgerIndexHandler::Input input, Context const& ctx) const
+LedgerIndexHandler::process(LedgerIndexHandler::Input const& input, Context const& ctx) const
 {
     auto const range = sharedPtrBackend_->fetchLedgerRange();
     ASSERT(range.has_value(), "LedgerIndex's ledger range must be available");

src/rpc/handlers/LedgerIndex.hpp

@@ -94,7 +94,7 @@ public:
      * @return The result of the operation
      */
     Result
-    process(Input input, Context const& ctx) const;
+    process(Input const& input, Context const& ctx) const;
 
 private:
     /**

src/rpc/handlers/MPTHolders.cpp

@@ -46,7 +46,7 @@ using namespace ripple;
 namespace rpc {
 
 MPTHoldersHandler::Result
-MPTHoldersHandler::process(MPTHoldersHandler::Input input, Context const& ctx) const
+MPTHoldersHandler::process(MPTHoldersHandler::Input const& input, Context const& ctx) const
 {
     auto const range = sharedPtrBackend_->fetchLedgerRange();
     ASSERT(range.has_value(), "MPTHolder's ledger range must be available");

src/rpc/handlers/MPTHolders.hpp

@@ -114,7 +114,7 @@ public:
      * @return The result of the operation
      */
     Result
-    process(Input input, Context const& ctx) const;
+    process(Input const& input, Context const& ctx) const;
 
 private:
     /**

src/rpc/handlers/NFTBuyOffers.cpp

@@ -29,7 +29,7 @@ using namespace ripple;
 namespace rpc {
 
 NFTBuyOffersHandler::Result
-NFTBuyOffersHandler::process(NFTBuyOffersHandler::Input input, Context const& ctx) const
+NFTBuyOffersHandler::process(NFTBuyOffersHandler::Input const& input, Context const& ctx) const
 {
     auto const tokenID = uint256{input.nftID.c_str()};
     auto const directory = keylet::nft_buys(tokenID);

src/rpc/handlers/NFTBuyOffers.hpp

@@ -52,6 +52,6 @@ public:
      * @return The result of the operation
      */
     Result
-    process(Input input, Context const& ctx) const;
+    process(Input const& input, Context const& ctx) const;
 };
 }  // namespace rpc

src/rpc/handlers/NFTHistory.cpp

@@ -50,7 +50,7 @@ namespace rpc {
 // TODO: this is currently very similar to account_tx but its own copy for time
 // being. we should aim to reuse common logic in some way in the future.
 NFTHistoryHandler::Result
-NFTHistoryHandler::process(NFTHistoryHandler::Input input, Context const& ctx) const
+NFTHistoryHandler::process(NFTHistoryHandler::Input const& input, Context const& ctx) const
 {
     auto const range = sharedPtrBackend_->fetchLedgerRange();
     ASSERT(range.has_value(), "NFTHistory's ledger range must be available");

src/rpc/handlers/NFTHistory.hpp

@@ -151,7 +151,7 @@ public:
      * @return The result of the operation
      */
     Result
-    process(Input input, Context const& ctx) const;
+    process(Input const& input, Context const& ctx) const;
 
 private:
     /**

src/rpc/handlers/NFTInfo.cpp

@@ -43,7 +43,7 @@ using namespace ripple;
 namespace rpc {
 
 NFTInfoHandler::Result
-NFTInfoHandler::process(NFTInfoHandler::Input input, Context const& ctx) const
+NFTInfoHandler::process(NFTInfoHandler::Input const& input, Context const& ctx) const
 {
     auto const tokenID = ripple::uint256{input.nftID.c_str()};
     auto const range = sharedPtrBackend_->fetchLedgerRange();

src/rpc/handlers/NFTInfo.hpp

@@ -111,7 +111,7 @@ public:
      * @return The result of the operation
      */
     Result
-    process(Input input, Context const& ctx) const;
+    process(Input const& input, Context const& ctx) const;
 
 private:
     /**

src/rpc/handlers/NFTSellOffers.cpp

@@ -29,7 +29,7 @@ using namespace ripple;
 namespace rpc {
 
 NFTSellOffersHandler::Result
-NFTSellOffersHandler::process(NFTSellOffersHandler::Input input, Context const& ctx) const
+NFTSellOffersHandler::process(NFTSellOffersHandler::Input const& input, Context const& ctx) const
 {
     auto const tokenID = uint256{input.nftID.c_str()};
     auto const directory = keylet::nft_sells(tokenID);

src/rpc/handlers/NFTSellOffers.hpp

@@ -52,7 +52,7 @@ public:
      * @return The result of the operation
      */
     Result
-    process(Input input, Context const& ctx) const;
+    process(Input const& input, Context const& ctx) const;
 };
 
 }  // namespace rpc

src/rpc/handlers/NFTsByIssuer.cpp

@@ -45,7 +45,7 @@ using namespace ripple;
 namespace rpc {
 
 NFTsByIssuerHandler::Result
-NFTsByIssuerHandler::process(NFTsByIssuerHandler::Input input, Context const& ctx) const
+NFTsByIssuerHandler::process(NFTsByIssuerHandler::Input const& input, Context const& ctx) const
 {
     auto const range = sharedPtrBackend_->fetchLedgerRange();
     ASSERT(range.has_value(), "NFTsByIssuer's ledger range must be available");

src/rpc/handlers/NFTsByIssuer.hpp

@@ -117,7 +117,7 @@ public:
      * @return The result of the operation
      */
     Result
-    process(Input input, Context const& ctx) const;
+    process(Input const& input, Context const& ctx) const;
 
 private:
     /**

src/rpc/handlers/NoRippleCheck.cpp

@@ -55,7 +55,7 @@
 namespace rpc {
 
 NoRippleCheckHandler::Result
-NoRippleCheckHandler::process(NoRippleCheckHandler::Input input, Context const& ctx) const
+NoRippleCheckHandler::process(NoRippleCheckHandler::Input const& input, Context const& ctx) const
 {
     auto const range = sharedPtrBackend_->fetchLedgerRange();
     ASSERT(range.has_value(), "NoRippleCheck's ledger range must be available");

src/rpc/handlers/NoRippleCheck.hpp

@@ -137,7 +137,7 @@ public:
      * @return The result of the operation
      */
     Result
-    process(Input input, Context const& ctx) const;
+    process(Input const& input, Context const& ctx) const;
 
 private:
     /**

src/rpc/handlers/ServerInfo.hpp

@@ -187,7 +187,7 @@ public:
      * @return The result of the operation
      */
     Result
-    process(Input input, Context const& ctx) const
+    process(Input const& input, Context const& ctx) const
     {
         using namespace rpc;
         using namespace std::chrono;

src/rpc/handlers/Subscribe.cpp

@@ -112,7 +112,7 @@ SubscribeHandler::spec([[maybe_unused]] uint32_t apiVersion)
 }
 
 SubscribeHandler::Result
-SubscribeHandler::process(Input input, Context const& ctx) const
+SubscribeHandler::process(Input const& input, Context const& ctx) const
 {
     auto output = Output{};
 

src/rpc/handlers/Subscribe.hpp

@@ -126,7 +126,7 @@ public:
      * @return The result of the operation
      */
     Result
-    process(Input input, Context const& ctx) const;
+    process(Input const& input, Context const& ctx) const;
 
 private:
     boost::json::object

src/rpc/handlers/TransactionEntry.cpp

@@ -39,7 +39,7 @@
 namespace rpc {
 
 TransactionEntryHandler::Result
-TransactionEntryHandler::process(TransactionEntryHandler::Input input, Context const& ctx) const
+TransactionEntryHandler::process(TransactionEntryHandler::Input const& input, Context const& ctx) const
 {
     auto const range = sharedPtrBackend_->fetchLedgerRange();
     ASSERT(range.has_value(), "TransactionEntry's ledger range must be available");

src/rpc/handlers/TransactionEntry.hpp

@@ -111,7 +111,7 @@ public:
      * @return The result of the command
      */
     Result
-    process(Input input, Context const& ctx) const;
+    process(Input const& input, Context const& ctx) const;
 
 private:
     /**

src/rpc/handlers/Tx.hpp

@@ -138,7 +138,7 @@ public:
      * @return The result of the operation
      */
     Result
-    process(Input input, Context const& ctx) const
+    process(Input const& input, Context const& ctx) const
     {
         if (input.ctid && input.transaction)  // ambiguous identifier
             return Error{Status{RippledError::rpcINVALID_PARAMS}};

src/rpc/handlers/Unsubscribe.cpp

@@ -86,7 +86,7 @@ UnsubscribeHandler::spec([[maybe_unused]] uint32_t apiVersion)
 }
 
 UnsubscribeHandler::Result
-UnsubscribeHandler::process(Input input, Context const& ctx) const
+UnsubscribeHandler::process(Input const& input, Context const& ctx) const
 {
     if (input.streams)
         unsubscribeFromStreams(*(input.streams), ctx.session);

src/rpc/handlers/Unsubscribe.hpp

@@ -96,7 +96,7 @@ public:
      * @return The result of the operation
      */
     Result
-    process(Input input, Context const& ctx) const;
+    process(Input const& input, Context const& ctx) const;
 
 private:
     void

src/rpc/handlers/VaultInfo.cpp

@@ -75,7 +75,7 @@ VaultInfoHandler::VaultInfoHandler(std::shared_ptr<BackendInterface> const& shar
 }
 
 VaultInfoHandler::Result
-VaultInfoHandler::process(VaultInfoHandler::Input input, Context const& ctx) const
+VaultInfoHandler::process(VaultInfoHandler::Input const& input, Context const& ctx) const
 {
     // vault info input must either have owner and sequence, or vault_id only.
     if (not validate(input))

src/rpc/handlers/VaultInfo.hpp

@@ -109,7 +109,7 @@ public:
      * @return The result of the operation
      */
     Result
-    process(Input input, Context const& ctx) const;
+    process(Input const& input, Context const& ctx) const;
 
 private:
     /**