ci: Specify bash as default shell in workflows (#2772)

.github/workflows/build-clio-docker-image.yml

@@ -38,6 +38,10 @@ on:
         description: Whether to strip clio binary
         default: true
 
+defaults:
+  run:
+    shell: bash
+
 jobs:
   build_and_publish_image:
     name: Build and publish image
@@ -55,7 +59,6 @@ jobs:
 
       - name: Download Clio binary from url
         if: ${{ inputs.clio_server_binary_url != null }}
-        shell: bash
         env:
           BINARY_URL: ${{ inputs.clio_server_binary_url }}
           BINARY_SHA256: ${{ inputs.binary_sha256 }}
@@ -66,7 +69,6 @@ jobs:
             exit 1
           fi
       - name: Unpack binary
-        shell: bash
         run: |
           sudo apt update && sudo apt install -y tar unzip
           cd docker/clio/artifact
@@ -83,7 +85,6 @@ jobs:
 
       - name: Strip binary
         if: ${{ inputs.strip_binary }}
-        shell: bash
         run: strip ./docker/clio/clio_server
 
       - name: Set GHCR_REPO

.github/workflows/build.yml

@@ -33,6 +33,10 @@ concurrency:
   group: ${{ github.workflow }}-${{ github.ref }}-${{ github.ref == 'refs/heads/develop' && github.run_number || 'branch' }}
   cancel-in-progress: true
 
+defaults:
+  run:
+    shell: bash
+
 jobs:
   build-and-test:
     name: Build and Test
@@ -121,7 +125,6 @@ jobs:
           name: clio_server_Linux_Release_gcc
 
       - name: Compare Config Description
-        shell: bash
         run: |
           repoConfigFile=docs/config-description.md
           configDescriptionFile=config_description_new.md

.github/workflows/check-libxrpl.yml

@@ -12,6 +12,10 @@ concurrency:
 env:
   CONAN_PROFILE: gcc
 
+defaults:
+  run:
+    shell: bash
+
 jobs:
   build:
     name: Build Clio / `libXRPL ${{ github.event.client_payload.version }}`
@@ -30,13 +34,11 @@ jobs:
           disable_ccache: true
 
       - name: Update libXRPL version requirement
-        shell: bash
         run: |
           sed -i.bak -E "s|'xrpl/[a-zA-Z0-9\\.\\-]+'|'xrpl/${{ github.event.client_payload.conan_ref }}'|g" conanfile.py
           rm -f conanfile.py.bak
 
       - name: Update conan lockfile
-        shell: bash
         run: |
           conan lock create . --profile:all ${{ env.CONAN_PROFILE }}
 

.github/workflows/check-pr-title.yml

@@ -5,6 +5,10 @@ on:
     types: [opened, edited, reopened, synchronize]
     branches: [develop]
 
+defaults:
+  run:
+    shell: bash
+
 jobs:
   check_title:
     runs-on: ubuntu-latest

.github/workflows/clang-tidy.yml

@@ -22,6 +22,10 @@ env:
   CONAN_PROFILE: clang
   LLVM_TOOLS_VERSION: 20
 
+defaults:
+  run:
+    shell: bash
+
 jobs:
   clang_tidy:
     if: github.event_name != 'push' || contains(github.event.head_commit.message, 'clang-tidy auto fixes')
@@ -67,21 +71,18 @@ jobs:
 
       - name: Run clang-tidy
         continue-on-error: true
-        shell: bash
         id: run_clang_tidy
         run: |
           run-clang-tidy-${{ env.LLVM_TOOLS_VERSION }} -p build -j "${{ steps.nproc.outputs.nproc }}" -fix -quiet 1>output.txt
 
       - name: Fix local includes and clang-format style
         if: ${{ steps.run_clang_tidy.outcome != 'success' }}
-        shell: bash
         run: |
           pre-commit run --all-files fix-local-includes || true
           pre-commit run --all-files clang-format || true
 
       - name: Print issues found
         if: ${{ steps.run_clang_tidy.outcome != 'success' }}
-        shell: bash
         run: |
           sed -i '/error\||/!d' ./output.txt
           cat output.txt
@@ -126,5 +127,4 @@ jobs:
 
       - name: Fail the job
         if: ${{ steps.run_clang_tidy.outcome != 'success' }}
-        shell: bash
         run: exit 1

.github/workflows/docs.yml

@@ -10,6 +10,10 @@ concurrency:
   group: ${{ github.workflow }}-${{ github.ref }}
   cancel-in-progress: true
 
+defaults:
+  run:
+    shell: bash
+
 jobs:
   build:
     runs-on: ubuntu-latest

.github/workflows/nightly.yml

@@ -23,6 +23,10 @@ concurrency:
   group: ${{ github.workflow }}-${{ github.ref }}
   cancel-in-progress: true
 
+defaults:
+  run:
+    shell: bash
+
 jobs:
   build-and-test:
     name: Build and Test

.github/workflows/reusable-build.yml

@@ -75,6 +75,10 @@ on:
       CODECOV_TOKEN:
         required: false
 
+defaults:
+  run:
+    shell: bash
+
 jobs:
   build:
     name: Build
@@ -101,7 +105,6 @@ jobs:
 
       - name: Setup conan on macOS
         if: ${{ runner.os == 'macOS' }}
-        shell: bash
         run: ./.github/scripts/conan/init.sh
 
       - name: Restore cache
@@ -141,7 +144,6 @@ jobs:
           ClangBuildAnalyzer --all build/ build_time_report.bin
           ClangBuildAnalyzer --analyze build_time_report.bin > build_time_report.txt
           cat build_time_report.txt
-        shell: bash
 
       - name: Upload build time analyze report
         if: ${{ inputs.analyze_build_time }}
@@ -152,7 +154,6 @@ jobs:
 
       - name: Show ccache's statistics
         if: ${{ inputs.download_ccache }}
-        shell: bash
         id: ccache_stats
         run: |
           ccache -s > /tmp/ccache.stats
@@ -220,7 +221,6 @@ jobs:
 
       - name: Verify expected version
         if: ${{ inputs.expected_version != '' }}
-        shell: bash
         env:
           INPUT_EXPECTED_VERSION: ${{ inputs.expected_version }}
         run: |

.github/workflows/reusable-release.yml

@@ -38,6 +38,10 @@ on:
         required: true
         type: boolean
 
+defaults:
+  run:
+    shell: bash
+
 jobs:
   release:
     runs-on: heavy
@@ -66,7 +70,6 @@ jobs:
           pattern: clio_server_*
 
       - name: Create release notes
-        shell: bash
         env:
           RELEASE_HEADER: ${{ inputs.header }}
         run: |
@@ -75,7 +78,6 @@ jobs:
           printf '%s\n' "${RELEASE_HEADER}" >> "${RUNNER_TEMP}/release_notes.md"
 
       - name: Generate changelog
-        shell: bash
         if: ${{ inputs.generate_changelog }}
         run: |
           LAST_TAG="$(gh release view --json tagName -q .tagName --repo XRPLF/clio)"
@@ -85,7 +87,6 @@ jobs:
           cat CHANGELOG.md >> "${RUNNER_TEMP}/release_notes.md"
 
       - name: Prepare release artifacts
-        shell: bash
         run: .github/scripts/prepare-release-artifacts.sh release_artifacts
 
       - name: Upload release notes
@@ -96,7 +97,6 @@ jobs:
 
       - name: Remove previous release with a pattern
         if: ${{ github.event_name != 'pull_request' && inputs.delete_pattern != '' }}
-        shell: bash
         env:
           DELETE_PATTERN: ${{ inputs.delete_pattern }}
         run: |
@@ -110,7 +110,6 @@ jobs:
 
       - name: Publish release
         if: ${{ github.event_name != 'pull_request' }}
-        shell: bash
         env:
           RELEASE_VERSION: ${{ inputs.version }}
           PRERELEASE_OPTION: ${{ inputs.prerelease && '--prerelease' || '' }}

.github/workflows/reusable-test.yml

@@ -33,6 +33,10 @@ on:
         required: true
         type: boolean
 
+defaults:
+  run:
+    shell: bash
+
 jobs:
   unit_tests:
     name: Unit testing
@@ -59,7 +63,6 @@ jobs:
           name: clio_tests_${{ runner.os }}_${{ inputs.build_type }}_${{ inputs.conan_profile }}
 
       - name: Make clio_tests executable
-        shell: bash
         run: chmod +x ./clio_tests
 
       - name: Run clio_tests (regular)
@@ -72,7 +75,6 @@ jobs:
 
       - name: Check for sanitizer report
         if: ${{ env.SANITIZER_IGNORE_ERRORS == 'true' }}
-        shell: bash
         id: check_report
         run: |
           if ls .sanitizer-report/* 1> /dev/null 2>&1; then

.github/workflows/reusable-upload-coverage-report.yml

@@ -6,6 +6,10 @@ on:
       CODECOV_TOKEN:
         required: true
 
+defaults:
+  run:
+    shell: bash
+
 jobs:
   upload_report:
     name: Upload report

.github/workflows/update-docker-ci.yml

@@ -33,6 +33,10 @@ env:
   GCC_MAJOR_VERSION: 15
   GCC_VERSION: 15.2.0
 
+defaults:
+  run:
+    shell: bash
+
 jobs:
   repo:
     name: Calculate repo name

.github/workflows/upload-conan-deps.yml

@@ -40,6 +40,10 @@ concurrency:
   group: ${{ github.workflow }}-${{ github.ref }}
   cancel-in-progress: true
 
+defaults:
+  run:
+    shell: bash
+
 jobs:
   generate-matrix:
     runs-on: ubuntu-latest
@@ -78,7 +82,6 @@ jobs:
 
       - name: Setup conan on macOS
         if: ${{ runner.os == 'macOS' }}
-        shell: bash
         run: ./.github/scripts/conan/init.sh
 
       - name: Show conan profile