chore: Fixes after tidy v22 update (#3108)

src/data/BackendInterface.cpp

@@ -223,7 +223,7 @@ BackendInterface::fetchBookOffers(
                           << " blob = " << ripple::strHex(objs[i])
                           << " ledgerSequence = " << ledgerSequence;
         ASSERT(!objs[i].empty(), "Ledger object can't be empty");
-        page.offers.push_back({keys[i], objs[i]});
+        page.offers.push_back({.key = keys[i], .blob = objs[i]});
     }
     auto end = std::chrono::system_clock::now();
     LOG(log_.debug()) << "Fetching " << std::to_string(keys.size()) << " offers took "
@@ -328,7 +328,7 @@ BackendInterface::fetchLedgerPage(
     auto objects = fetchLedgerObjects(keys, ledgerSequence, yield);
     for (size_t i = 0; i < objects.size(); ++i) {
         if (!objects[i].empty()) {
-            page.objects.push_back({keys[i], std::move(objects[i])});
+            page.objects.push_back({.key = keys[i], .blob = std::move(objects[i])});
         } else if (!outOfOrder) {
             LOG(log_.error()) << "Deleted or non-existent object in successor table. key = "
                               << ripple::strHex(keys[i]) << " - seq = " << ledgerSequence;

src/data/cassandra/impl/ExecutionStrategy.hpp

@@ -119,7 +119,7 @@ public:
     /**
      * @return true if outstanding read requests allowance is exhausted; false otherwise
      */
-    bool
+    [[nodiscard]] bool
     isTooBusy() const
     {
         bool const result = numReadRequestsOutstanding_ >= maxReadRequestsOutstanding_;
@@ -495,7 +495,7 @@ public:
     /**
      * @brief Get statistics about the backend.
      */
-    boost::json::object
+    [[nodiscard]] boost::json::object
     stats() const
     {
         return counters_->report();
@@ -536,13 +536,13 @@ private:
         }
     }
 
-    bool
+    [[nodiscard]] bool
     canAddWriteRequest() const
     {
         return numWriteRequestsOutstanding_ < maxWriteRequestsOutstanding_;
     }
 
-    bool
+    [[nodiscard]] bool
     finishedAllWriteRequests() const
     {
         return numWriteRequestsOutstanding_ == 0;