ARCHIVE/clio
1
0
Fork 0
mirror of https://github.com/XRPLF/clio.git synced 2026-06-03 00:36:44 +00:00
Code Issues Packages Projects Releases Wiki Activity

chore: Enable more clang-tidy checks (#3054)

Browse Source
This commit is contained in:
Alex Kremer
2026-05-01 15:31:45 +01:00
committed by GitHub
parent d6bae6c12b
commit 51244feb4a
239 changed files with 1150 additions and 733 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
tests/unit/util/prometheus/HttpTests.cpp
View File

@@ -100,9 +100,11 @@ TEST_F(PrometheusHandleRequestTests, emptyResponse)
{
auto response = handlePrometheusRequest(req, true);
ASSERT_TRUE(response.has_value());
// NOLINTBEGIN(bugprone-unchecked-optional-access)
EXPECT_EQ(response->result(), http::status::ok);
EXPECT_EQ(response->operator[](http::field::content_type), "text/plain; version=0.0.4");
EXPECT_EQ(response->body(), "");
// NOLINTEND(bugprone-unchecked-optional-access)
}
struct PrometheusDisabledHandleRequestTests : util::prometheus::WithPrometheusDisabled,
@@ -112,6 +114,7 @@ TEST_F(PrometheusDisabledHandleRequestTests, prometheusDisabled)
{
auto response = handlePrometheusRequest(req, true);
ASSERT_TRUE(response.has_value());
// NOLINTNEXTLINE(bugprone-unchecked-optional-access)
EXPECT_EQ(response->result(), http::status::forbidden);
}
@@ -119,6 +122,7 @@ TEST_F(PrometheusHandleRequestTests, notAdmin)
{
auto response = handlePrometheusRequest(req, false);
ASSERT_TRUE(response.has_value());
// NOLINTNEXTLINE(bugprone-unchecked-optional-access)
EXPECT_EQ(response->result(), http::status::unauthorized);
}
@@ -134,6 +138,7 @@ TEST_F(PrometheusHandleRequestTests, responseWithCounter)
auto response = handlePrometheusRequest(req, true);
ASSERT_TRUE(response.has_value());
// NOLINTBEGIN(bugprone-unchecked-optional-access)
EXPECT_EQ(response->result(), http::status::ok);
EXPECT_EQ(response->operator[](http::field::content_type), "text/plain; version=0.0.4");
auto const expectedBody = fmt::format(
@@ -143,6 +148,7 @@ TEST_F(PrometheusHandleRequestTests, responseWithCounter)
labels.serialize()
);
EXPECT_EQ(response->body(), expectedBody);
// NOLINTEND(bugprone-unchecked-optional-access)
}
TEST_F(PrometheusHandleRequestTests, responseWithGauge)
@@ -157,6 +163,7 @@ TEST_F(PrometheusHandleRequestTests, responseWithGauge)
auto response = handlePrometheusRequest(req, true);
ASSERT_TRUE(response.has_value());
// NOLINTBEGIN(bugprone-unchecked-optional-access)
EXPECT_EQ(response->result(), http::status::ok);
EXPECT_EQ(response->operator[](http::field::content_type), "text/plain; version=0.0.4");
auto const expectedBody = fmt::format(
@@ -166,6 +173,7 @@ TEST_F(PrometheusHandleRequestTests, responseWithGauge)
labels.serialize()
);
EXPECT_EQ(response->body(), expectedBody);
// NOLINTEND(bugprone-unchecked-optional-access)
}
TEST_F(PrometheusHandleRequestTests, responseWithCounterAndGauge)
@@ -188,7 +196,8 @@ TEST_F(PrometheusHandleRequestTests, responseWithCounterAndGauge)
auto response = handlePrometheusRequest(req, true);
EXPECT_EQ(response->result(), http::status::ok);
EXPECT_EQ(response->result(), http::status::ok); // NOLINT(bugprone-unchecked-optional-access)
// NOLINTNEXTLINE(bugprone-unchecked-optional-access)
EXPECT_EQ(response->operator[](http::field::content_type), "text/plain; version=0.0.4");
auto const expectedBody = fmt::format(
"# HELP {3} {4}\n# TYPE {3} gauge\n{3}{5} -2\n\n"
@@ -210,6 +219,7 @@ TEST_F(PrometheusHandleRequestTests, responseWithCounterAndGauge)
gaugeDescription,
gaugeLabels.serialize()
);
// NOLINTNEXTLINE(bugprone-unchecked-optional-access)
EXPECT_TRUE(response->body() == expectedBody || response->body() == anotherExpectedBody);
}
@@ -227,8 +237,10 @@ TEST_F(PrometheusHandleRequestTests, compressReply)
auto response = handlePrometheusRequest(req, true);
ASSERT_TRUE(response.has_value());
// NOLINTBEGIN(bugprone-unchecked-optional-access)
EXPECT_EQ(response->result(), http::status::ok);
EXPECT_EQ(response->operator[](http::field::content_type), "text/plain; version=0.0.4");
EXPECT_EQ(response->operator[](http::field::content_encoding), "gzip");
EXPECT_GT(response->body().size(), 0ul);
// NOLINTEND(bugprone-unchecked-optional-access)
}