ARCHIVE/clio
1
0
Fork 0
mirror of https://github.com/XRPLF/clio.git synced 2026-06-03 00:36:44 +00:00
Code Issues Packages Projects Releases Wiki Activity

chore: Enable more clang-tidy checks (#3054)

Browse Source
This commit is contained in:
Alex Kremer
2026-05-01 15:31:45 +01:00
committed by GitHub
parent d6bae6c12b
commit 51244feb4a
239 changed files with 1150 additions and 733 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
tests/unit/data/LedgerCacheTests.cpp
View File

@@ -129,11 +129,11 @@ TEST_F(LedgerCacheSaveLoadTest, saveAndLoadFromFile)
auto const blob1 = cache.get(key1, kLEDGER_SEQ);
ASSERT_TRUE(blob1.has_value());
EXPECT_EQ(blob1.value(), objs.front().data);
EXPECT_EQ(blob1.value(), objs.front().data); // NOLINT(bugprone-unchecked-optional-access)
auto const blob2 = cache.get(key2, kLEDGER_SEQ);
ASSERT_TRUE(blob2.has_value());
EXPECT_EQ(blob2.value(), objs.back().data);
EXPECT_EQ(blob2.value(), objs.back().data); // NOLINT(bugprone-unchecked-optional-access)
auto const tmpFile = TmpFile::empty();
auto const saveResult = cache.saveToFile(tmpFile.path);
@@ -149,11 +149,11 @@ TEST_F(LedgerCacheSaveLoadTest, saveAndLoadFromFile)
auto const loadedBlob1 = newCache.get(key1, kLEDGER_SEQ);
ASSERT_TRUE(loadedBlob1.has_value());
EXPECT_EQ(loadedBlob1.value(), blob1);
EXPECT_EQ(loadedBlob1.value(), blob1); // NOLINT(bugprone-unchecked-optional-access)
auto const loadedBlob2 = newCache.get(key2, kLEDGER_SEQ);
ASSERT_TRUE(loadedBlob2.has_value());
EXPECT_EQ(loadedBlob2.value(), blob2);
EXPECT_EQ(loadedBlob2.value(), blob2); // NOLINT(bugprone-unchecked-optional-access)
EXPECT_EQ(newCache.latestLedgerSequence(), cache.latestLedgerSequence());
}
@@ -174,10 +174,11 @@ TEST_F(LedgerCacheSaveLoadTest, saveAndLoadFromFileWithDeletedObjects)
auto const blob2 = cache.get(key2, kLEDGER_SEQ);
ASSERT_TRUE(blob2.has_value());
EXPECT_EQ(blob2.value(), objs.back().data);
EXPECT_EQ(blob2.value(), objs.back().data); // NOLINT(bugprone-unchecked-optional-access)
auto const deletedBlob = cache.getDeleted(key1, kLEDGER_SEQ - 1);
ASSERT_TRUE(deletedBlob.has_value());
// NOLINTNEXTLINE(bugprone-unchecked-optional-access)
EXPECT_EQ(deletedBlob.value(), objs.front().data);
// Save and load
@@ -192,6 +193,7 @@ TEST_F(LedgerCacheSaveLoadTest, saveAndLoadFromFileWithDeletedObjects)
// Verify deleted object is preserved
auto const loadedDeletedBlob = newCache.getDeleted(key1, kLEDGER_SEQ - 1);
ASSERT_TRUE(loadedDeletedBlob.has_value());
// NOLINTNEXTLINE(bugprone-unchecked-optional-access)
EXPECT_EQ(loadedDeletedBlob.value(), deletedBlob);
// Verify active object
@@ -200,7 +202,7 @@ TEST_F(LedgerCacheSaveLoadTest, saveAndLoadFromFileWithDeletedObjects)
auto const loadedBlob2 = newCache.get(key2, kLEDGER_SEQ);
ASSERT_TRUE(loadedBlob2.has_value());
EXPECT_EQ(loadedBlob2.value(), blob2);
EXPECT_EQ(loadedBlob2.value(), blob2); // NOLINT(bugprone-unchecked-optional-access)
EXPECT_TRUE(newCache.isFull());
EXPECT_EQ(newCache.latestLedgerSequence(), cache.latestLedgerSequence());