ARCHIVE/clio
1
0
Fork 0
mirror of https://github.com/XRPLF/clio.git synced 2026-07-24 23:50:18 +00:00
Code Issues Packages Projects Releases Wiki Activity

chore: Enable more clang-tidy checks (#3054)

Browse Source
This commit is contained in:
Alex Kremer
2026-05-01 15:31:45 +01:00
committed by GitHub
parent d6bae6c12b
commit 51244feb4a
239 changed files with 1150 additions and 733 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
src/app/WebHandlers.cpp
View File

@@ -83,7 +83,7 @@ MetricsHandler::operator()(
ASSERT(onTaskComplete.has_value(), "Coroutine group can't be full");
bool const postSuccessful = workQueue_.get().postCoro(
[this, &request, &response, &onTaskComplete = onTaskComplete.value(), &connectionMetadata](
[this, &request, &response, &onTaskComplete = *onTaskComplete, &connectionMetadata]( // NOLINT(bugprone-unchecked-optional-access)
boost::asio::yield_context
) mutable {
auto const maybeHttpRequest = request.asHttpRequest();
@@ -94,7 +94,7 @@ MetricsHandler::operator()(
httpRequest, adminVerifier_->isAdmin(httpRequest, connectionMetadata.ip())
);
ASSERT(maybeResponse.has_value(), "Got unexpected request for Prometheus");
response = web::ng::Response{std::move(maybeResponse).value(), request};
response = web::ng::Response{*std::move(maybeResponse), request};
// notify the coroutine group that the foreign task is done
onTaskComplete();
},
@@ -114,7 +114,7 @@ MetricsHandler::operator()(
coroutineGroup.asyncWait(yield);
ASSERT(response.has_value(), "Woke up coroutine without setting response");
return std::move(response).value();
return *std::move(response); // NOLINT(bugprone-unchecked-optional-access)
}
web::ng::Response