Fix race condition and ub (#631)

This commit is contained in:
Alex Kremer
2023-05-10 18:35:04 +01:00
committed by GitHub
parent b3db4cadab
commit 4cae248b5c
17 changed files with 416 additions and 324 deletions

View File

@@ -22,6 +22,8 @@
#include <rpc/Errors.h>
#include <util/Expected.h>
#include <ripple/basics/base_uint.h>
#include <boost/asio/spawn.hpp>
#include <boost/json/value.hpp>
@@ -71,6 +73,26 @@ struct Context
std::string clientIp;
};
using Result = std::variant<Status, boost::json::object>;
struct AccountCursor
{
ripple::uint256 index;
std::uint32_t hint;
std::string
toString() const
{
return ripple::strHex(index) + "," + std::to_string(hint);
}
bool
isNonZero() const
{
return index.isNonZero() || hint != 0;
}
};
class AnyHandler;
class HandlerProvider

View File

@@ -0,0 +1,42 @@
//------------------------------------------------------------------------------
/*
This file is part of clio: https://github.com/XRPLF/clio
Copyright (c) 2023, the clio developers.
Permission to use, copy, modify, and distribute this software for any
purpose with or without fee is hereby granted, provided that the above
copyright notice and this permission notice appear in all copies.
THE SOFTWARE IS PROVIDED "AS IS" AND THE AUTHOR DISCLAIMS ALL WARRANTIES
WITH REGARD TO THIS SOFTWARE INCLUDING ALL IMPLIED WARRANTIES OF
MERCHANTABILITY AND FITNESS. IN NO EVENT SHALL THE AUTHOR BE LIABLE FOR
ANY SPECIAL, DIRECT, INDIRECT, OR CONSEQUENTIAL DAMAGES OR ANY DAMAGES
WHATSOEVER RESULTING FROM LOSS OF USE, DATA OR PROFITS, WHETHER IN AN
ACTION OF CONTRACT, NEGLIGENCE OR OTHER TORTIOUS ACTION, ARISING OUT OF
OR IN CONNECTION WITH THE USE OR PERFORMANCE OF THIS SOFTWARE.
*/
//==============================================================================
#pragma once
#include <string_view>
namespace RPC::detail {
class IPAdminVerificationStrategy final
{
public:
/**
* @brief Checks whether request is from a host that is considered authorized as admin.
*
* @param ip The ip addr of the client
* @return true if authorized; false otherwise
*/
bool
isAdmin(std::string_view ip) const
{
return ip == "127.0.0.1";
}
};
} // namespace RPC::detail