ARCHIVE/clio
1
0
Fork 0
mirror of https://github.com/XRPLF/clio.git synced 2025-12-01 09:05:51 +00:00
Code Issues Packages Projects Releases Wiki Activity

Use custom malformedAddress error in ledger_entry (#419)

Browse Source 
Fixes #272
This commit is contained in:
Alex Kremer
2022-11-22 22:18:10 +00:00
committed by GitHub
parent 75c0d22f87
commit 4b94ed3e55
3 changed files with 9 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
src/rpc/Errors.cpp
View File

@@ -59,6 +59,9 @@ getErrorInfo(ClioError code)
"malformedRequest",
"Malformed request."},
{ClioError::rpcMALFORMED_OWNER, "malformedOwner", "Malformed owner."},
{ClioError::rpcMALFORMED_ADDRESS,
"malformedAddress",
"Malformed address."},
};
auto matchByCode = [code](auto const& info) { return info.code == code; };

1
src/rpc/Errors.h
View File

@@ -19,6 +19,7 @@ enum class ClioError {
rpcMALFORMED_CURRENCY = 5000,
rpcMALFORMED_REQUEST = 5001,
rpcMALFORMED_OWNER = 5002,
rpcMALFORMED_ADDRESS = 5003,
};
/**

13
src/rpc/handlers/LedgerEntry.cpp
View File

@@ -49,7 +49,7 @@ doLedgerEntry(Context const& context)
auto const account = ripple::parseBase58<ripple::AccountID>(
request.at(JS(account_root)).as_string().c_str());
if (!account || account->isZero())
return Status{RippledError::rpcINVALID_PARAMS, "malformedAddress"};
return Status{ClioError::rpcMALFORMED_ADDRESS};
else
key = ripple::keylet::account(*account).key;
}
@@ -175,8 +175,7 @@ doLedgerEntry(Context const& context)
if (!ownerID)
{
return Status{
RippledError::rpcINVALID_PARAMS, "malformedAddress"};
return Status{ClioError::rpcMALFORMED_ADDRESS};
}
else
{
@@ -222,8 +221,7 @@ doLedgerEntry(Context const& context)
.c_str());
if (!id)
return Status{
RippledError::rpcINVALID_PARAMS, "malformedAddress"};
return Status{ClioError::rpcMALFORMED_ADDRESS};
else
{
std::uint32_t seq =
@@ -259,8 +257,7 @@ doLedgerEntry(Context const& context)
offer.at(JS(account)).as_string().c_str());
if (!id)
return Status{
RippledError::rpcINVALID_PARAMS, "malformedAddress"};
return Status{ClioError::rpcMALFORMED_ADDRESS};
else
{
std::uint32_t seq =
@@ -313,7 +310,7 @@ doLedgerEntry(Context const& context)
if (!id1 || !id2)
return Status{
RippledError::rpcINVALID_PARAMS, "malformedAddresses"};
ClioError::rpcMALFORMED_ADDRESS, "malformedAddresses"};
else if (!ripple::to_currency(
currency, state.at(JS(currency)).as_string().c_str()))