Add clang tidy (#864)

Fixes #863
This commit is contained in:
Sergey Kuznetsov
2023-10-03 10:43:54 +01:00
committed by GitHub
parent 69f5025a29
commit 4b53bef1f5
198 changed files with 2168 additions and 1288 deletions

View File

@@ -168,7 +168,8 @@ TEST_P(AccountObjectsParameterTest, InvalidParams)
TEST_F(RPCAccountObjectsHandlerTest, LedgerNonExistViaIntSequence)
{
auto const rawBackendPtr = static_cast<MockBackend*>(mockBackendPtr.get());
auto const rawBackendPtr = dynamic_cast<MockBackend*>(mockBackendPtr.get());
ASSERT_NE(rawBackendPtr, nullptr);
mockBackendPtr->updateRange(MINSEQ); // min
mockBackendPtr->updateRange(MAXSEQ); // max
EXPECT_CALL(*rawBackendPtr, fetchLedgerBySequence).Times(1);
@@ -194,7 +195,8 @@ TEST_F(RPCAccountObjectsHandlerTest, LedgerNonExistViaIntSequence)
TEST_F(RPCAccountObjectsHandlerTest, LedgerNonExistViaStringSequence)
{
auto const rawBackendPtr = static_cast<MockBackend*>(mockBackendPtr.get());
auto const rawBackendPtr = dynamic_cast<MockBackend*>(mockBackendPtr.get());
ASSERT_NE(rawBackendPtr, nullptr);
mockBackendPtr->updateRange(MINSEQ); // min
mockBackendPtr->updateRange(MAXSEQ); // max
EXPECT_CALL(*rawBackendPtr, fetchLedgerBySequence).Times(1);
@@ -219,7 +221,8 @@ TEST_F(RPCAccountObjectsHandlerTest, LedgerNonExistViaStringSequence)
TEST_F(RPCAccountObjectsHandlerTest, LedgerNonExistViaHash)
{
auto const rawBackendPtr = static_cast<MockBackend*>(mockBackendPtr.get());
auto const rawBackendPtr = dynamic_cast<MockBackend*>(mockBackendPtr.get());
ASSERT_NE(rawBackendPtr, nullptr);
mockBackendPtr->updateRange(MINSEQ); // min
mockBackendPtr->updateRange(MAXSEQ); // max
EXPECT_CALL(*rawBackendPtr, fetchLedgerByHash).Times(1);
@@ -246,7 +249,8 @@ TEST_F(RPCAccountObjectsHandlerTest, LedgerNonExistViaHash)
TEST_F(RPCAccountObjectsHandlerTest, AccountNotExist)
{
auto const rawBackendPtr = static_cast<MockBackend*>(mockBackendPtr.get());
auto const rawBackendPtr = dynamic_cast<MockBackend*>(mockBackendPtr.get());
ASSERT_NE(rawBackendPtr, nullptr);
mockBackendPtr->updateRange(MINSEQ); // min
mockBackendPtr->updateRange(MAXSEQ); // max
auto const ledgerinfo = CreateLedgerInfo(LEDGERHASH, MAXSEQ);
@@ -305,7 +309,8 @@ TEST_F(RPCAccountObjectsHandlerTest, DefaultParameterNoNFTFound)
]
})";
auto const rawBackendPtr = static_cast<MockBackend*>(mockBackendPtr.get());
auto const rawBackendPtr = dynamic_cast<MockBackend*>(mockBackendPtr.get());
ASSERT_NE(rawBackendPtr, nullptr);
mockBackendPtr->updateRange(MINSEQ); // min
mockBackendPtr->updateRange(MAXSEQ); // max
auto const ledgerinfo = CreateLedgerInfo(LEDGERHASH, MAXSEQ);
@@ -349,7 +354,8 @@ TEST_F(RPCAccountObjectsHandlerTest, DefaultParameterNoNFTFound)
TEST_F(RPCAccountObjectsHandlerTest, Limit)
{
auto const rawBackendPtr = static_cast<MockBackend*>(mockBackendPtr.get());
auto const rawBackendPtr = dynamic_cast<MockBackend*>(mockBackendPtr.get());
ASSERT_NE(rawBackendPtr, nullptr);
mockBackendPtr->updateRange(MINSEQ); // min
mockBackendPtr->updateRange(MAXSEQ); // max
auto const ledgerinfo = CreateLedgerInfo(LEDGERHASH, MAXSEQ);
@@ -402,7 +408,8 @@ TEST_F(RPCAccountObjectsHandlerTest, Limit)
TEST_F(RPCAccountObjectsHandlerTest, Marker)
{
auto const rawBackendPtr = static_cast<MockBackend*>(mockBackendPtr.get());
auto const rawBackendPtr = dynamic_cast<MockBackend*>(mockBackendPtr.get());
ASSERT_NE(rawBackendPtr, nullptr);
mockBackendPtr->updateRange(MINSEQ); // min
mockBackendPtr->updateRange(MAXSEQ); // max
auto const ledgerinfo = CreateLedgerInfo(LEDGERHASH, MAXSEQ);
@@ -451,7 +458,8 @@ TEST_F(RPCAccountObjectsHandlerTest, Marker)
TEST_F(RPCAccountObjectsHandlerTest, MultipleDirNoNFT)
{
auto const rawBackendPtr = static_cast<MockBackend*>(mockBackendPtr.get());
auto const rawBackendPtr = dynamic_cast<MockBackend*>(mockBackendPtr.get());
ASSERT_NE(rawBackendPtr, nullptr);
mockBackendPtr->updateRange(MINSEQ); // min
mockBackendPtr->updateRange(MAXSEQ); // max
auto const ledgerinfo = CreateLedgerInfo(LEDGERHASH, MAXSEQ);
@@ -511,7 +519,8 @@ TEST_F(RPCAccountObjectsHandlerTest, MultipleDirNoNFT)
TEST_F(RPCAccountObjectsHandlerTest, TypeFilter)
{
auto const rawBackendPtr = static_cast<MockBackend*>(mockBackendPtr.get());
auto const rawBackendPtr = dynamic_cast<MockBackend*>(mockBackendPtr.get());
ASSERT_NE(rawBackendPtr, nullptr);
mockBackendPtr->updateRange(MINSEQ); // min
mockBackendPtr->updateRange(MAXSEQ); // max
auto const ledgerinfo = CreateLedgerInfo(LEDGERHASH, MAXSEQ);
@@ -567,7 +576,8 @@ TEST_F(RPCAccountObjectsHandlerTest, TypeFilter)
TEST_F(RPCAccountObjectsHandlerTest, TypeFilterReturnEmpty)
{
auto const rawBackendPtr = static_cast<MockBackend*>(mockBackendPtr.get());
auto const rawBackendPtr = dynamic_cast<MockBackend*>(mockBackendPtr.get());
ASSERT_NE(rawBackendPtr, nullptr);
mockBackendPtr->updateRange(MINSEQ); // min
mockBackendPtr->updateRange(MAXSEQ); // max
auto const ledgerinfo = CreateLedgerInfo(LEDGERHASH, MAXSEQ);
@@ -622,7 +632,8 @@ TEST_F(RPCAccountObjectsHandlerTest, TypeFilterReturnEmpty)
TEST_F(RPCAccountObjectsHandlerTest, DeletionBlockersOnlyFilter)
{
auto const rawBackendPtr = static_cast<MockBackend*>(mockBackendPtr.get());
auto const rawBackendPtr = dynamic_cast<MockBackend*>(mockBackendPtr.get());
ASSERT_NE(rawBackendPtr, nullptr);
mockBackendPtr->updateRange(MINSEQ); // min
mockBackendPtr->updateRange(MAXSEQ); // max
@@ -684,7 +695,8 @@ TEST_F(RPCAccountObjectsHandlerTest, DeletionBlockersOnlyFilter)
TEST_F(RPCAccountObjectsHandlerTest, DeletionBlockersOnlyFilterWithTypeFilter)
{
auto const rawBackendPtr = static_cast<MockBackend*>(mockBackendPtr.get());
auto const rawBackendPtr = dynamic_cast<MockBackend*>(mockBackendPtr.get());
ASSERT_NE(rawBackendPtr, nullptr);
mockBackendPtr->updateRange(MINSEQ); // min
mockBackendPtr->updateRange(MAXSEQ); // max
@@ -735,7 +747,8 @@ TEST_F(RPCAccountObjectsHandlerTest, DeletionBlockersOnlyFilterWithTypeFilter)
TEST_F(RPCAccountObjectsHandlerTest, DeletionBlockersOnlyFilterEmptyResult)
{
auto const rawBackendPtr = static_cast<MockBackend*>(mockBackendPtr.get());
auto const rawBackendPtr = dynamic_cast<MockBackend*>(mockBackendPtr.get());
ASSERT_NE(rawBackendPtr, nullptr);
mockBackendPtr->updateRange(MINSEQ); // min
mockBackendPtr->updateRange(MAXSEQ); // max
@@ -802,7 +815,8 @@ TEST_F(RPCAccountObjectsHandlerTest, DeletionBlockersOnlyFilterEmptyResult)
TEST_F(RPCAccountObjectsHandlerTest, DeletionBlockersOnlyFilterWithIncompatibleTypeYieldsEmptyResult)
{
auto const rawBackendPtr = static_cast<MockBackend*>(mockBackendPtr.get());
auto const rawBackendPtr = dynamic_cast<MockBackend*>(mockBackendPtr.get());
ASSERT_NE(rawBackendPtr, nullptr);
mockBackendPtr->updateRange(MINSEQ); // min
mockBackendPtr->updateRange(MAXSEQ); // max
@@ -931,7 +945,8 @@ TEST_F(RPCAccountObjectsHandlerTest, NFTMixOtherObjects)
]
})";
auto const rawBackendPtr = static_cast<MockBackend*>(mockBackendPtr.get());
auto const rawBackendPtr = dynamic_cast<MockBackend*>(mockBackendPtr.get());
ASSERT_NE(rawBackendPtr, nullptr);
mockBackendPtr->updateRange(MINSEQ); // min
mockBackendPtr->updateRange(MAXSEQ); // max
auto const ledgerinfo = CreateLedgerInfo(LEDGERHASH, MAXSEQ);
@@ -985,7 +1000,8 @@ TEST_F(RPCAccountObjectsHandlerTest, NFTMixOtherObjects)
TEST_F(RPCAccountObjectsHandlerTest, NFTReachLimitReturnMarker)
{
auto const rawBackendPtr = static_cast<MockBackend*>(mockBackendPtr.get());
auto const rawBackendPtr = dynamic_cast<MockBackend*>(mockBackendPtr.get());
ASSERT_NE(rawBackendPtr, nullptr);
mockBackendPtr->updateRange(MINSEQ); // min
mockBackendPtr->updateRange(MAXSEQ); // max
auto const ledgerinfo = CreateLedgerInfo(LEDGERHASH, MAXSEQ);
@@ -1034,7 +1050,8 @@ TEST_F(RPCAccountObjectsHandlerTest, NFTReachLimitReturnMarker)
TEST_F(RPCAccountObjectsHandlerTest, NFTReachLimitNoMarker)
{
auto const rawBackendPtr = static_cast<MockBackend*>(mockBackendPtr.get());
auto const rawBackendPtr = dynamic_cast<MockBackend*>(mockBackendPtr.get());
ASSERT_NE(rawBackendPtr, nullptr);
mockBackendPtr->updateRange(MINSEQ); // min
mockBackendPtr->updateRange(MAXSEQ); // max
auto const ledgerinfo = CreateLedgerInfo(LEDGERHASH, MAXSEQ);
@@ -1088,7 +1105,8 @@ TEST_F(RPCAccountObjectsHandlerTest, NFTReachLimitNoMarker)
TEST_F(RPCAccountObjectsHandlerTest, NFTMarker)
{
auto const rawBackendPtr = static_cast<MockBackend*>(mockBackendPtr.get());
auto const rawBackendPtr = dynamic_cast<MockBackend*>(mockBackendPtr.get());
ASSERT_NE(rawBackendPtr, nullptr);
mockBackendPtr->updateRange(MINSEQ); // min
mockBackendPtr->updateRange(MAXSEQ); // max
auto const ledgerinfo = CreateLedgerInfo(LEDGERHASH, MAXSEQ);
@@ -1168,7 +1186,8 @@ TEST_F(RPCAccountObjectsHandlerTest, NFTMarker)
// when limit reached, happen to be the end of NFT page list
TEST_F(RPCAccountObjectsHandlerTest, NFTMarkerNoMoreNFT)
{
auto const rawBackendPtr = static_cast<MockBackend*>(mockBackendPtr.get());
auto const rawBackendPtr = dynamic_cast<MockBackend*>(mockBackendPtr.get());
ASSERT_NE(rawBackendPtr, nullptr);
mockBackendPtr->updateRange(MINSEQ); // min
mockBackendPtr->updateRange(MAXSEQ); // max
auto const ledgerinfo = CreateLedgerInfo(LEDGERHASH, MAXSEQ);
@@ -1227,7 +1246,8 @@ TEST_F(RPCAccountObjectsHandlerTest, NFTMarkerNoMoreNFT)
TEST_F(RPCAccountObjectsHandlerTest, NFTMarkerNotInRange)
{
auto const rawBackendPtr = static_cast<MockBackend*>(mockBackendPtr.get());
auto const rawBackendPtr = dynamic_cast<MockBackend*>(mockBackendPtr.get());
ASSERT_NE(rawBackendPtr, nullptr);
mockBackendPtr->updateRange(MINSEQ); // min
mockBackendPtr->updateRange(MAXSEQ); // max
auto const ledgerinfo = CreateLedgerInfo(LEDGERHASH, MAXSEQ);
@@ -1260,7 +1280,8 @@ TEST_F(RPCAccountObjectsHandlerTest, NFTMarkerNotInRange)
TEST_F(RPCAccountObjectsHandlerTest, NFTMarkerNotExist)
{
auto const rawBackendPtr = static_cast<MockBackend*>(mockBackendPtr.get());
auto const rawBackendPtr = dynamic_cast<MockBackend*>(mockBackendPtr.get());
ASSERT_NE(rawBackendPtr, nullptr);
mockBackendPtr->updateRange(MINSEQ); // min
mockBackendPtr->updateRange(MAXSEQ); // max
auto const ledgerinfo = CreateLedgerInfo(LEDGERHASH, MAXSEQ);
@@ -1297,7 +1318,8 @@ TEST_F(RPCAccountObjectsHandlerTest, NFTMarkerNotExist)
TEST_F(RPCAccountObjectsHandlerTest, NFTLimitAdjust)
{
auto const rawBackendPtr = static_cast<MockBackend*>(mockBackendPtr.get());
auto const rawBackendPtr = dynamic_cast<MockBackend*>(mockBackendPtr.get());
ASSERT_NE(rawBackendPtr, nullptr);
mockBackendPtr->updateRange(MINSEQ); // min
mockBackendPtr->updateRange(MAXSEQ); // max
auto const ledgerinfo = CreateLedgerInfo(LEDGERHASH, MAXSEQ);
@@ -1418,7 +1440,8 @@ TEST_F(RPCAccountObjectsHandlerTest, FilterNFT)
]
})";
auto const rawBackendPtr = static_cast<MockBackend*>(mockBackendPtr.get());
auto const rawBackendPtr = dynamic_cast<MockBackend*>(mockBackendPtr.get());
ASSERT_NE(rawBackendPtr, nullptr);
mockBackendPtr->updateRange(MINSEQ); // min
mockBackendPtr->updateRange(MAXSEQ); // max
auto const ledgerinfo = CreateLedgerInfo(LEDGERHASH, MAXSEQ);
@@ -1473,7 +1496,8 @@ TEST_F(RPCAccountObjectsHandlerTest, FilterNFT)
TEST_F(RPCAccountObjectsHandlerTest, NFTZeroMarkerNotAffectOtherMarker)
{
auto const rawBackendPtr = static_cast<MockBackend*>(mockBackendPtr.get());
auto const rawBackendPtr = dynamic_cast<MockBackend*>(mockBackendPtr.get());
ASSERT_NE(rawBackendPtr, nullptr);
mockBackendPtr->updateRange(MINSEQ); // min
mockBackendPtr->updateRange(MAXSEQ); // max
auto const ledgerinfo = CreateLedgerInfo(LEDGERHASH, MAXSEQ);
@@ -1559,7 +1583,8 @@ TEST_F(RPCAccountObjectsHandlerTest, LimitLessThanMin)
}})",
AccountObjectsHandler::LIMIT_MIN);
auto const rawBackendPtr = static_cast<MockBackend*>(mockBackendPtr.get());
auto const rawBackendPtr = dynamic_cast<MockBackend*>(mockBackendPtr.get());
ASSERT_NE(rawBackendPtr, nullptr);
mockBackendPtr->updateRange(MINSEQ); // min
mockBackendPtr->updateRange(MAXSEQ); // max
auto const ledgerinfo = CreateLedgerInfo(LEDGERHASH, MAXSEQ);
@@ -1639,7 +1664,8 @@ TEST_F(RPCAccountObjectsHandlerTest, LimitMoreThanMax)
}})",
AccountObjectsHandler::LIMIT_MAX);
auto const rawBackendPtr = static_cast<MockBackend*>(mockBackendPtr.get());
auto const rawBackendPtr = dynamic_cast<MockBackend*>(mockBackendPtr.get());
ASSERT_NE(rawBackendPtr, nullptr);
mockBackendPtr->updateRange(MINSEQ); // min
mockBackendPtr->updateRange(MAXSEQ); // max
auto const ledgerinfo = CreateLedgerInfo(LEDGERHASH, MAXSEQ);