ARCHIVE/clio
1
0
Fork 0
mirror of https://github.com/XRPLF/clio.git synced 2025-12-06 17:27:58 +00:00
Code Issues Packages Projects Releases Wiki Activity

Add rpcLGR_IDX_MALFORMED error messages to ledger sequence min and max out of range conditionals (#336)

Browse Source
This commit is contained in:
Francis Mendoza
2022-10-03 12:28:21 -07:00
committed by GitHub
parent 744af4b639
commit 49387059ef
1 changed files with 2 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
src/rpc/RPCHelpers.cpp
View File

@@ -1,8 +1,6 @@
#include <boost/algorithm/string.hpp> #include <boost/algorithm/string.hpp>
#include <backend/BackendInterface.h> #include <backend/BackendInterface.h>
#include <rpc/RPCHelpers.h> #include <rpc/RPCHelpers.h>
#include <webserver/WsBase.h>
namespace RPC { namespace RPC {
std::optional<bool> std::optional<bool>
@@ -1473,7 +1471,6 @@ parseTaker(boost::json::value const& taker)
return Status{Error::rpcINVALID_PARAMS, "invalidTakerAccount"}; return Status{Error::rpcINVALID_PARAMS, "invalidTakerAccount"};
return *takerID; return *takerID;
} }
bool bool
specifiesCurrentOrClosedLedger(boost::json::object const& request) specifiesCurrentOrClosedLedger(boost::json::object const& request)
{ {
@@ -1571,7 +1568,7 @@ traverseTransactions(
if (context.range.maxSequence < min.as_int64() || if (context.range.maxSequence < min.as_int64() ||
context.range.minSequence > min.as_int64()) context.range.minSequence > min.as_int64())
return Status{ return Status{
Error::rpcINVALID_PARAMS, "ledgerSeqMinOutOfRange"}; Error::rpcLGR_IDX_MALFORMED, "ledgerSeqMinOutOfRange"};
else else
minIndex = boost::json::value_to<std::uint32_t>(min); minIndex = boost::json::value_to<std::uint32_t>(min);
} }
@@ -1593,7 +1590,7 @@ traverseTransactions(
if (context.range.maxSequence < max.as_int64() || if (context.range.maxSequence < max.as_int64() ||
context.range.minSequence > max.as_int64()) context.range.minSequence > max.as_int64())
return Status{ return Status{
Error::rpcINVALID_PARAMS, "ledgerSeqMaxOutOfRange"}; Error::rpcLGR_IDX_MALFORMED, "ledgerSeqMaxOutOfRange"};
else else
maxIndex = boost::json::value_to<std::uint32_t>(max); maxIndex = boost::json::value_to<std::uint32_t>(max);
} }