ARCHIVE/clio
1
0
Fork 0
mirror of https://github.com/XRPLF/clio.git synced 2025-11-22 20:55:52 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: Flaky test in ETLng (#2077)

Browse Source 
Fixes a flaky test

Fix: https://github.com/XRPLF/clio/issues/2075

---------

Co-authored-by: Ayaz Salikhov <mathbunnyru@users.noreply.github.com>
This commit is contained in:
Alex Kremer
2025-05-02 15:55:12 +01:00
committed by GitHub
parent 5d2c2a8bfc
commit 3daa735b31
2 changed files with 3 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
tests/common/util/TestObject.cpp
View File

@@ -89,6 +89,8 @@ createLedgerHeader(std::string_view ledgerHash, ripple::LedgerIndex seq, std::op
ledgerHeader.seq = seq; ledgerHeader.seq = seq;
if (age) { if (age) {
// Note: be cautious of using age values close to each other as the underlying NetClock precision is seconds
// and the small time difference may lead to comparison bugs
auto const now = duration_cast<seconds>(system_clock::now().time_since_epoch()); auto const now = duration_cast<seconds>(system_clock::now().time_since_epoch());
auto const closeTime = (now - seconds{age.value()}).count() - kRIPPLE_EPOCH_START; auto const closeTime = (now - seconds{age.value()}).count() - kRIPPLE_EPOCH_START;
ledgerHeader.closeTime = ripple::NetClock::time_point{seconds{closeTime}}; ledgerHeader.closeTime = ripple::NetClock::time_point{seconds{closeTime}};

2
tests/unit/etlng/ExtractionTests.cpp
View File

@@ -92,7 +92,7 @@ TEST_F(ExtractionModelNgTests, LedgerDataCopyableAndEquatable)
} }
{ {
auto third = second; auto third = second;
third.header = createLedgerHeader(kLEDGER_HASH2, kSEQ, 2); third.header = createLedgerHeader(kLEDGER_HASH2, kSEQ, 100); // Using large age value to avoid flaky test
EXPECT_NE(first, third); EXPECT_NE(first, third);
} }
{ {