From 3d3b8e91b664f8a461c414b2563e50cfef89383a Mon Sep 17 00:00:00 2001 From: Nathan Nichols Date: Wed, 15 Jun 2022 16:18:57 -0500 Subject: [PATCH] fix ledger_index_min/max in account_tx response (#172) --- src/rpc/handlers/AccountTx.cpp | 14 ++++---------- 1 file changed, 4 insertions(+), 10 deletions(-) diff --git a/src/rpc/handlers/AccountTx.cpp b/src/rpc/handlers/AccountTx.cpp index fe0a44de0..d201a5e66 100644 --- a/src/rpc/handlers/AccountTx.cpp +++ b/src/rpc/handlers/AccountTx.cpp @@ -65,7 +65,7 @@ doAccountTx(Context const& context) if (context.range.maxSequence < min.as_int64() || context.range.minSequence > min.as_int64()) return Status{ - Error::rpcINVALID_PARAMS, "ledgerSeqMaxOutOfRange"}; + Error::rpcINVALID_PARAMS, "ledgerSeqMinOutOfRange"}; else minIndex = value_to(min); } @@ -189,21 +189,15 @@ doAccountTx(Context const& context) } assert(cursor); - if (forward) + if (!forward) { response[JS(ledger_index_min)] = cursor->ledgerSequence; - if (blobs.size() >= limit) - response[JS(ledger_index_max)] = *maxReturnedIndex; - else - response[JS(ledger_index_max)] = maxIndex; + response[JS(ledger_index_max)] = maxIndex; } else { response[JS(ledger_index_max)] = cursor->ledgerSequence; - if (blobs.size() >= limit) - response[JS(ledger_index_min)] = *minReturnedIndex; - else - response[JS(ledger_index_min)] = minIndex; + response[JS(ledger_index_min)] = minIndex; } response[JS(transactions)] = txns;