style: clang-tidy auto fixes (#2184)

Fixes #2183. Please review and commit clang-tidy fixes. Co-authored-by: mathbunnyru <12270691+mathbunnyru@users.noreply.github.com>
2025-11-22 20:55:52 +00:00 · 2025-06-03 18:15:08 +01:00
parent 550f0fae85
commit 357b96ab0d
34 changed files with 7 additions and 42 deletions
--- a/src/rpc/RPCEngine.hpp
+++ b/src/rpc/RPCEngine.hpp
@@ -166,9 +166,9 @@ public:

                auto const extracted =
                    [&result]() -> std::expected<boost::json::object, util::ResponseExpirationCache::Error> {
-                    if (result.response.has_value())
+                    if (result.response.has_value()) {
                        return std::move(result.response).value();
-                    else
+                    }
                    return std::unexpected{util::ResponseExpirationCache::Error{
                        .status = std::move(result.response).error(), .warnings = std::move(result.warnings)
                    }};
--- a/src/rpc/RPCHelpers.cpp
+++ b/src/rpc/RPCHelpers.cpp
@@ -99,7 +99,6 @@
 #include <string>
 #include <string_view>
 #include <utility>
-#include <variant>
 #include <vector>

 // local to compilation unit loggers
@@ -1417,10 +1416,11 @@ parseBook(boost::json::object const& request)
        if (!takerGets["issuer"].is_string())
            return std::unexpected{Status{RippledError::rpcINVALID_PARAMS, "taker_gets.issuer should be string"}};

-        if (!ripple::to_issuer(getIssuer, boost::json::value_to<std::string>(takerGets.at("issuer"))))
+        if (!ripple::to_issuer(getIssuer, boost::json::value_to<std::string>(takerGets.at("issuer")))) {
            return std::unexpected{
                Status{RippledError::rpcDST_ISR_MALFORMED, "Invalid field 'taker_gets.issuer', bad issuer."}
            };
+        }

        if (getIssuer == ripple::noAccount()) {
            return std::unexpected{
--- a/src/rpc/handlers/AMMInfo.cpp
+++ b/src/rpc/handlers/AMMInfo.cpp
@@ -57,7 +57,6 @@
 #include <string>
 #include <string_view>
 #include <utility>
-#include <variant>

 namespace {

--- a/src/rpc/handlers/AccountChannels.cpp
+++ b/src/rpc/handlers/AccountChannels.cpp
@@ -44,7 +44,6 @@
 #include <optional>
 #include <string>
 #include <utility>
-#include <variant>
 #include <vector>

 namespace rpc {
--- a/src/rpc/handlers/AccountCurrencies.cpp
+++ b/src/rpc/handlers/AccountCurrencies.cpp
@@ -40,7 +40,6 @@
 #include <cstdint>
 #include <limits>
 #include <string>
-#include <variant>

 namespace rpc {
 AccountCurrenciesHandler::Result
--- a/src/rpc/handlers/AccountInfo.cpp
+++ b/src/rpc/handlers/AccountInfo.cpp
@@ -46,7 +46,6 @@
 #include <string>
 #include <string_view>
 #include <utility>
-#include <variant>
 #include <vector>

 namespace rpc {
--- a/src/rpc/handlers/AccountLines.cpp
+++ b/src/rpc/handlers/AccountLines.cpp
@@ -43,7 +43,6 @@
 #include <optional>
 #include <string>
 #include <utility>
-#include <variant>
 #include <vector>

 namespace rpc {
--- a/src/rpc/handlers/AccountNFTs.cpp
+++ b/src/rpc/handlers/AccountNFTs.cpp
@@ -45,7 +45,6 @@
 #include <cstdint>
 #include <optional>
 #include <string>
-#include <variant>

 namespace rpc {

--- a/src/rpc/handlers/AccountObjects.cpp
+++ b/src/rpc/handlers/AccountObjects.cpp
@@ -44,7 +44,6 @@
 #include <unordered_map>
 #include <unordered_set>
 #include <utility>
-#include <variant>
 #include <vector>

 namespace rpc {
--- a/src/rpc/handlers/AccountOffers.cpp
+++ b/src/rpc/handlers/AccountOffers.cpp
@@ -41,7 +41,6 @@
 #include <xrpl/protocol/jss.h>

 #include <string>
-#include <variant>
 #include <vector>

 namespace rpc {
--- a/src/rpc/handlers/AccountTx.cpp
+++ b/src/rpc/handlers/AccountTx.cpp
@@ -46,7 +46,6 @@
 #include <optional>
 #include <string>
 #include <utility>
-#include <variant>

 namespace rpc {

--- a/src/rpc/handlers/BookChanges.cpp
+++ b/src/rpc/handlers/BookChanges.cpp
@@ -21,7 +21,6 @@

 #include "data/Types.hpp"
 #include "rpc/BookChangesHelper.hpp"
-#include "rpc/Errors.hpp"
 #include "rpc/JS.hpp"
 #include "rpc/RPCHelpers.hpp"
 #include "rpc/common/Types.hpp"
@@ -37,7 +36,6 @@
 #include <xrpl/protocol/jss.h>

 #include <string>
-#include <variant>
 #include <vector>

 namespace rpc {
--- a/src/rpc/handlers/BookOffers.cpp
+++ b/src/rpc/handlers/BookOffers.cpp
@@ -19,7 +19,6 @@

 #include "rpc/handlers/BookOffers.hpp"

-#include "rpc/Errors.hpp"
 #include "rpc/JS.hpp"
 #include "rpc/RPCHelpers.hpp"
 #include "rpc/common/Types.hpp"
@@ -39,7 +38,6 @@
 #include <xrpl/protocol/jss.h>

 #include <string>
-#include <variant>

 namespace rpc {

--- a/src/rpc/handlers/DepositAuthorized.cpp
+++ b/src/rpc/handlers/DepositAuthorized.cpp
@@ -45,7 +45,6 @@
 #include <memory>
 #include <string>
 #include <utility>
-#include <variant>

 namespace rpc {

--- a/src/rpc/handlers/Feature.cpp
+++ b/src/rpc/handlers/Feature.cpp
@@ -45,7 +45,6 @@
 #include <ranges>
 #include <string>
 #include <utility>
-#include <variant>
 #include <vector>

 namespace rpc {
--- a/src/rpc/handlers/GatewayBalances.cpp
+++ b/src/rpc/handlers/GatewayBalances.cpp
@@ -50,7 +50,6 @@
 #include <stdexcept>
 #include <string>
 #include <utility>
-#include <variant>
 #include <vector>

 namespace rpc {
--- a/src/rpc/handlers/GetAggregatePrice.cpp
+++ b/src/rpc/handlers/GetAggregatePrice.cpp
@@ -54,7 +54,6 @@
 #include <numeric>
 #include <optional>
 #include <string>
-#include <variant>

 namespace rpc {

--- a/src/rpc/handlers/Ledger.cpp
+++ b/src/rpc/handlers/Ledger.cpp
@@ -20,7 +20,6 @@
 #include "rpc/handlers/Ledger.hpp"

 #include "data/Types.hpp"
-#include "rpc/Errors.hpp"
 #include "rpc/JS.hpp"
 #include "rpc/RPCHelpers.hpp"
 #include "rpc/common/Types.hpp"
@@ -46,7 +45,6 @@
 #include <iterator>
 #include <string>
 #include <utility>
-#include <variant>

 namespace rpc {
 LedgerHandler::Result
--- a/src/rpc/handlers/LedgerData.cpp
+++ b/src/rpc/handlers/LedgerData.cpp
@@ -46,7 +46,6 @@
 #include <cstddef>
 #include <string>
 #include <utility>
-#include <variant>
 #include <vector>

 namespace rpc {
--- a/src/rpc/handlers/LedgerEntry.cpp
+++ b/src/rpc/handlers/LedgerEntry.cpp
@@ -54,7 +54,6 @@
 #include <string_view>
 #include <unordered_map>
 #include <utility>
-#include <variant>

 namespace rpc {

--- a/src/rpc/handlers/MPTHolders.cpp
+++ b/src/rpc/handlers/MPTHolders.cpp
@@ -40,7 +40,6 @@

 #include <optional>
 #include <string>
-#include <variant>

 using namespace ripple;

--- a/src/rpc/handlers/NFTHistory.cpp
+++ b/src/rpc/handlers/NFTHistory.cpp
@@ -44,7 +44,6 @@
 #include <optional>
 #include <string>
 #include <utility>
-#include <variant>

 namespace rpc {

--- a/src/rpc/handlers/NFTInfo.cpp
+++ b/src/rpc/handlers/NFTInfo.cpp
@@ -37,7 +37,6 @@
 #include <xrpl/protocol/nft.h>

 #include <string>
-#include <variant>

 using namespace ripple;

--- a/src/rpc/handlers/NFTOffersCommon.cpp
+++ b/src/rpc/handlers/NFTOffersCommon.cpp
@@ -48,7 +48,6 @@
 #include <memory>
 #include <string>
 #include <utility>
-#include <variant>
 #include <vector>

 using namespace ripple;
--- a/src/rpc/handlers/NFTsByIssuer.cpp
+++ b/src/rpc/handlers/NFTsByIssuer.cpp
@@ -39,7 +39,6 @@

 #include <optional>
 #include <string>
-#include <variant>

 using namespace ripple;

--- a/src/rpc/handlers/NoRippleCheck.cpp
+++ b/src/rpc/handlers/NoRippleCheck.cpp
@@ -51,7 +51,6 @@
 #include <optional>
 #include <string>
 #include <utility>
-#include <variant>

 namespace rpc {

--- a/src/rpc/handlers/Subscribe.cpp
+++ b/src/rpc/handlers/Subscribe.cpp
@@ -49,7 +49,6 @@
 #include <optional>
 #include <string>
 #include <string_view>
-#include <variant>
 #include <vector>

 namespace rpc {
--- a/src/rpc/handlers/TransactionEntry.cpp
+++ b/src/rpc/handlers/TransactionEntry.cpp
@@ -36,7 +36,6 @@

 #include <string>
 #include <utility>
-#include <variant>

 namespace rpc {

--- a/src/rpc/handlers/Unsubscribe.cpp
+++ b/src/rpc/handlers/Unsubscribe.cpp
@@ -40,7 +40,6 @@
 #include <memory>
 #include <string>
 #include <string_view>
-#include <variant>
 #include <vector>

 namespace rpc {
--- a/tests/unit/rpc/ForwardingProxyTests.cpp
+++ b/tests/unit/rpc/ForwardingProxyTests.cpp
@@ -39,7 +39,6 @@
 #include <memory>
 #include <optional>
 #include <string>
-#include <variant>
 #include <vector>

 using namespace rpc;
--- a/tests/unit/rpc/RPCEngineTests.cpp
+++ b/tests/unit/rpc/RPCEngineTests.cpp
@@ -53,7 +53,6 @@
 #include <memory>
 #include <optional>
 #include <string>
-#include <variant>
 #include <vector>

 using namespace data;
--- a/tests/unit/rpc/RPCHelpersTests.cpp
+++ b/tests/unit/rpc/RPCHelpersTests.cpp
@@ -62,7 +62,6 @@
 #include <string>
 #include <string_view>
 #include <tuple>
-#include <variant>
 #include <vector>

 using namespace data;
--- a/tests/unit/rpc/handlers/BookOffersTests.cpp
+++ b/tests/unit/rpc/handlers/BookOffersTests.cpp
@@ -37,7 +37,6 @@
 #include <xrpl/basics/Blob.h>
 #include <xrpl/basics/base_uint.h>
 #include <xrpl/protocol/AccountID.h>
-#include <xrpl/protocol/Book.h>
 #include <xrpl/protocol/Indexes.h>
 #include <xrpl/protocol/LedgerFormats.h>
 #include <xrpl/protocol/LedgerHeader.h>
--- a/tests/unit/rpc/handlers/SubscribeTests.cpp
+++ b/tests/unit/rpc/handlers/SubscribeTests.cpp
@@ -39,7 +39,6 @@
 #include <gtest/gtest.h>
 #include <xrpl/basics/base_uint.h>
 #include <xrpl/protocol/AccountID.h>
-#include <xrpl/protocol/Book.h>
 #include <xrpl/protocol/Indexes.h>
 #include <xrpl/protocol/UintTypes.h>