From 32aeda0ce759b1cfd5d2c8513724f4862056d605 Mon Sep 17 00:00:00 2001 From: Ayaz Salikhov Date: Wed, 29 Apr 2026 16:17:32 +0100 Subject: [PATCH] chore: Fix clang-tidy 21 issues (#3052) --- src/migration/cassandra/impl/Spec.hpp | 2 +- tests/unit/feed/SubscriptionManagerTests.cpp | 4 +-- tests/unit/rpc/handlers/ServerInfoTests.cpp | 38 ++++++++++---------- 3 files changed, 22 insertions(+), 22 deletions(-) diff --git a/src/migration/cassandra/impl/Spec.hpp b/src/migration/cassandra/impl/Spec.hpp index 819115042..9daa12bc9 100644 --- a/src/migration/cassandra/impl/Spec.hpp +++ b/src/migration/cassandra/impl/Spec.hpp @@ -13,7 +13,7 @@ concept TableSpec = requires { // Check that 'row' exists and is a tuple // keys types are at the beginning and the other fields types sort in alphabetical order typename T::Row; - requires std::tuple_size::value >= 0; // Ensures 'row' is a tuple + requires std::tuple_size_v >= 0; // Ensures 'row' is a tuple // Check that static constexpr members 'partitionKey' and 'tableName' exist { T::kPARTITION_KEY } -> std::convertible_to; diff --git a/tests/unit/feed/SubscriptionManagerTests.cpp b/tests/unit/feed/SubscriptionManagerTests.cpp index 3c7f57061..328bdb9c4 100644 --- a/tests/unit/feed/SubscriptionManagerTests.cpp +++ b/tests/unit/feed/SubscriptionManagerTests.cpp @@ -120,10 +120,10 @@ TEST_F(SubscriptionManagerTest, ReportCurrentSubscriber) "book_changes": 2 })JSON"; web::SubscriptionContextPtr const session1 = std::make_shared(); - MockSession* mockSession1 = dynamic_cast(session1.get()); + auto const* mockSession1 = dynamic_cast(session1.get()); web::SubscriptionContextPtr session2 = std::make_shared(); - MockSession* mockSession2 = dynamic_cast(session2.get()); + auto const* mockSession2 = dynamic_cast(session2.get()); std::vector session2OnDisconnectSlots; ON_CALL(*mockSession2, onDisconnect).WillByDefault([&session2OnDisconnectSlots](auto slot) { session2OnDisconnectSlots.push_back(slot); diff --git a/tests/unit/rpc/handlers/ServerInfoTests.cpp b/tests/unit/rpc/handlers/ServerInfoTests.cpp index 7deeab8f9..c35e5a4cb 100644 --- a/tests/unit/rpc/handlers/ServerInfoTests.cpp +++ b/tests/unit/rpc/handlers/ServerInfoTests.cpp @@ -166,8 +166,8 @@ TEST_F(RPCServerInfoHandlerTest, NoFeesErrorsOutWithInternal) TEST_F(RPCServerInfoHandlerTest, DefaultOutputIsPresent) { MockLoadBalancer* rawBalancerPtr = mockLoadBalancerPtr_.get(); - MockCounters* rawCountersPtr = mockCountersPtr_.get(); - MockETLService* rawETLServicePtr = mockETLServicePtr_.get(); + MockCounters const* rawCountersPtr = mockCountersPtr_.get(); + MockETLService const* rawETLServicePtr = mockETLServicePtr_.get(); auto const ledgerHeader = createLedgerHeader(kLEDGER_HASH, 30, 3); // 3 seconds old EXPECT_CALL(*backend_, fetchLedgerBySequence).WillOnce(Return(ledgerHeader)); @@ -209,8 +209,8 @@ TEST_F(RPCServerInfoHandlerTest, DefaultOutputIsPresent) TEST_F(RPCServerInfoHandlerTest, AmendmentBlockedIsPresentIfSet) { MockLoadBalancer* rawBalancerPtr = mockLoadBalancerPtr_.get(); - MockCounters* rawCountersPtr = mockCountersPtr_.get(); - MockETLService* rawETLServicePtr = mockETLServicePtr_.get(); + MockCounters const* rawCountersPtr = mockCountersPtr_.get(); + MockETLService const* rawETLServicePtr = mockETLServicePtr_.get(); auto const ledgerHeader = createLedgerHeader(kLEDGER_HASH, 30, 3); // 3 seconds old EXPECT_CALL(*backend_, fetchLedgerBySequence).WillOnce(Return(ledgerHeader)); @@ -250,8 +250,8 @@ TEST_F(RPCServerInfoHandlerTest, AmendmentBlockedIsPresentIfSet) TEST_F(RPCServerInfoHandlerTest, CorruptionDetectedIsPresentIfSet) { MockLoadBalancer* rawBalancerPtr = mockLoadBalancerPtr_.get(); - MockCounters* rawCountersPtr = mockCountersPtr_.get(); - MockETLService* rawETLServicePtr = mockETLServicePtr_.get(); + MockCounters const* rawCountersPtr = mockCountersPtr_.get(); + MockETLService const* rawETLServicePtr = mockETLServicePtr_.get(); auto const ledgerHeader = createLedgerHeader(kLEDGER_HASH, 30, 3); // 3 seconds old EXPECT_CALL(*backend_, fetchLedgerBySequence).WillOnce(Return(ledgerHeader)); @@ -291,7 +291,7 @@ TEST_F(RPCServerInfoHandlerTest, CorruptionDetectedIsPresentIfSet) TEST_F(RPCServerInfoHandlerTest, CacheReportsEnabledFlagCorrectly) { MockLoadBalancer* rawBalancerPtr = mockLoadBalancerPtr_.get(); - MockCounters* rawCountersPtr = mockCountersPtr_.get(); + MockCounters const* rawCountersPtr = mockCountersPtr_.get(); auto const ledgerHeader = createLedgerHeader(kLEDGER_HASH, 30, 3); // 3 seconds old EXPECT_CALL(*backend_, fetchLedgerBySequence).Times(2).WillRepeatedly(Return(ledgerHeader)); @@ -346,9 +346,9 @@ TEST_F(RPCServerInfoHandlerTest, CacheReportsEnabledFlagCorrectly) TEST_F(RPCServerInfoHandlerTest, AdminSectionPresentWhenAdminFlagIsSet) { - MockLoadBalancer* rawBalancerPtr = mockLoadBalancerPtr_.get(); - MockCounters* rawCountersPtr = mockCountersPtr_.get(); - MockETLService* rawETLServicePtr = mockETLServicePtr_.get(); + MockLoadBalancer const* rawBalancerPtr = mockLoadBalancerPtr_.get(); + MockCounters const* rawCountersPtr = mockCountersPtr_.get(); + MockETLService const* rawETLServicePtr = mockETLServicePtr_.get(); auto const empty = json::object{}; auto const ledgerHeader = createLedgerHeader(kLEDGER_HASH, 30, 3); // 3 seconds old @@ -389,9 +389,9 @@ TEST_F(RPCServerInfoHandlerTest, AdminSectionPresentWhenAdminFlagIsSet) TEST_F(RPCServerInfoHandlerTest, BackendCountersPresentWhenRequestWithParam) { - MockLoadBalancer* rawBalancerPtr = mockLoadBalancerPtr_.get(); - MockCounters* rawCountersPtr = mockCountersPtr_.get(); - MockETLService* rawETLServicePtr = mockETLServicePtr_.get(); + MockLoadBalancer const* rawBalancerPtr = mockLoadBalancerPtr_.get(); + MockCounters const* rawCountersPtr = mockCountersPtr_.get(); + MockETLService const* rawETLServicePtr = mockETLServicePtr_.get(); auto const empty = json::object{}; auto const ledgerHeader = createLedgerHeader(kLEDGER_HASH, 30, 3); // 3 seconds old @@ -439,9 +439,9 @@ TEST_F(RPCServerInfoHandlerTest, BackendCountersPresentWhenRequestWithParam) TEST_F(RPCServerInfoHandlerTest, RippledForwardedValuesPresent) { - MockLoadBalancer* rawBalancerPtr = mockLoadBalancerPtr_.get(); - MockCounters* rawCountersPtr = mockCountersPtr_.get(); - MockETLService* rawETLServicePtr = mockETLServicePtr_.get(); + MockLoadBalancer const* rawBalancerPtr = mockLoadBalancerPtr_.get(); + MockCounters const* rawCountersPtr = mockCountersPtr_.get(); + MockETLService const* rawETLServicePtr = mockETLServicePtr_.get(); auto const empty = json::object{}; auto const ledgerHeader = createLedgerHeader(kLEDGER_HASH, 30, 3); // 3 seconds old @@ -493,9 +493,9 @@ TEST_F(RPCServerInfoHandlerTest, RippledForwardedValuesPresent) TEST_F(RPCServerInfoHandlerTest, RippledForwardedValuesMissingNoExceptionThrown) { - MockLoadBalancer* rawBalancerPtr = mockLoadBalancerPtr_.get(); - MockCounters* rawCountersPtr = mockCountersPtr_.get(); - MockETLService* rawETLServicePtr = mockETLServicePtr_.get(); + MockLoadBalancer const* rawBalancerPtr = mockLoadBalancerPtr_.get(); + MockCounters const* rawCountersPtr = mockCountersPtr_.get(); + MockETLService const* rawETLServicePtr = mockETLServicePtr_.get(); auto const empty = json::object{}; auto const ledgerHeader = createLedgerHeader(kLEDGER_HASH, 30, 3); // 3 seconds old