ARCHIVE/clio
1
0
Fork 0
mirror of https://github.com/XRPLF/clio.git synced 2025-12-06 17:27:58 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix noRippleCheck fee field (#786)

Browse Source 
Fixes #709
This commit is contained in:
Arihant Kothari
2023-07-26 14:22:17 -04:00
committed by GitHub
parent 71aabc8c29
commit 1d0a43669b
6 changed files with 5 additions and 17 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
unittests/rpc/handlers/NoRippleCheckTest.cpp
View File

@@ -616,14 +616,14 @@ TEST_F(RPCNoRippleCheckTest, NormalPathTransactions)
{{
"Sequence":{},
"Account":"rf1BiGeXwwQoi8Z2ueFYTEXSwuJYfV2Jpn",
"Fee":4,
"Fee":1,
"TransactionType":"AccountSet",
"SetFlag":8
}},
{{
"Sequence":{},
"Account":"rf1BiGeXwwQoi8Z2ueFYTEXSwuJYfV2Jpn",
"Fee":4,
"Fee":1,
"TransactionType":"TrustSet",
"LimitAmount":{{
"currency":"USD",
@@ -635,7 +635,7 @@ TEST_F(RPCNoRippleCheckTest, NormalPathTransactions)
{{
"Sequence":{},
"Account":"rf1BiGeXwwQoi8Z2ueFYTEXSwuJYfV2Jpn",
"Fee":4,
"Fee":1,
"TransactionType":"TrustSet",
"LimitAmount":{{
"currency":"USD",

2
unittests/rpc/handlers/SubscribeTest.cpp
View File

@@ -588,7 +588,6 @@ TEST_F(RPCSubscribeHandlerTest, StreamsLedger)
"ledger_index":30,
"ledger_hash":"4BC50C9B0D8515D3EAAE1E74B29A95804346C491EE1A95BF25E4AAB854A6A652",
"ledger_time":0,
"fee_ref":4,
"fee_base":1,
"reserve_base":3,
"reserve_inc":2
@@ -615,7 +614,6 @@ TEST_F(RPCSubscribeHandlerTest, StreamsLedger)
auto const handler = AnyHandler{SubscribeHandler{mockBackendPtr, subManager_}};
auto const output = handler.process(input, Context{std::ref(yield), session_});
ASSERT_TRUE(output);
// FIXME: fee_ref is missing now. this is possibly correct. need to confirm:
EXPECT_EQ(output->as_object(), json::parse(expectedOutput));
std::this_thread::sleep_for(20ms);
auto const report = subManager_->report();