From 1ce82412dba14428671ab83fb68aa376095ab6ac Mon Sep 17 00:00:00 2001
From: CJ Cobb <ccobb@ripple.com>
Date: Mon, 8 Feb 2021 10:42:35 -0500
Subject: [PATCH] add marker to book offers

---
 handlers/BookOffers.cpp      | 17 +++++++++++++++--
 reporting/ReportingBackend.h | 22 ++++++++++++++++++----
 2 files changed, 33 insertions(+), 6 deletions(-)

diff --git a/handlers/BookOffers.cpp b/handlers/BookOffers.cpp
index 9617067d..c77280bc 100644
--- a/handlers/BookOffers.cpp
+++ b/handlers/BookOffers.cpp
@@ -297,13 +297,26 @@ doBookOffers(
         request.at("limit").kind() == boost::json::kind::int64)
         limit = request.at("limit").as_int64();
 
+    ripple::uint256 cursor;
+    if (request.contains("cursor"))
+    {
+        cursor.parseHex(request.at("cursor").as_string().c_str());
+    }
+
     ripple::Book book = {
         {pay_currency, pay_issuer}, {get_currency, get_issuer}};
 
     auto start = std::chrono::system_clock::now();
     ripple::uint256 bookBase = getBookBase(book);
-    std::vector<CassandraFlatMapBackend::LedgerObject> offers =
-        backend.doBookOffers(bookBase, *sequence);
+    std::vector<CassandraFlatMapBackend::LedgerObject> offers;
+    if (!cursor.isZero())
+    {
+        offers = backend.doBookOffers(bookBase, *sequence, cursor);
+    }
+    else
+    {
+        offers = backend.doBookOffers(bookBase, *sequence);
+    }
     auto end = std::chrono::system_clock::now();
 
     BOOST_LOG_TRIVIAL(warning) << "Time loading books from Postgres: "
diff --git a/reporting/ReportingBackend.h b/reporting/ReportingBackend.h
index d0e30a81..94b86f79 100644
--- a/reporting/ReportingBackend.h
+++ b/reporting/ReportingBackend.h
@@ -487,7 +487,7 @@ public:
             query << "CREATE TABLE IF NOT EXISTS " << tableName << "books"
                   << " ( book blob, sequence bigint, key blob, deleted_at "
                      "bigint, PRIMARY KEY "
-                     "(book, key))";
+                     "(book, key)) WITH CLUSTERING ORDER BY (key ASC)";
             statement = makeStatement(query.str().c_str(), 0);
             fut = cass_session_execute(session_.get(), statement);
             rc = cass_future_error_code(fut);
@@ -810,8 +810,9 @@ public:
 
             query = {};
             query << "SELECT key FROM " << tableName << "books "
-                  << " WHERE book = ? AND sequence <= ? AND deleted_at > ? "
-                     "ALLOW FILTERING";
+                  << " WHERE book = ? AND sequence <= ? AND deleted_at > ? AND"
+                     " key > ? "
+                     " ORDER BY key ASC LIMIT 300 ALLOW FILTERING";
 
             prepare_future =
                 cass_session_prepare(session_.get(), query.str().c_str());
@@ -1242,7 +1243,10 @@ public:
     }
 
     std::vector<LedgerObject>
-    doBookOffers(ripple::uint256 const& book, uint32_t sequence) const
+    doBookOffers(
+        ripple::uint256 const& book,
+        uint32_t sequence,
+        ripple::uint256 const& cursor = {}) const
     {
         BOOST_LOG_TRIVIAL(debug) << "Starting doBookOffers";
         CassStatement* statement = cass_prepared_bind(getBook_);
@@ -1277,7 +1281,17 @@ public:
                 << ", " << cass_error_desc(rc);
             return {};
         }
+        rc = cass_statement_bind_bytes(
+            statement, 3, static_cast<cass_byte_t const*>(cursor.data()), 32);
 
+        if (rc != CASS_OK)
+        {
+            cass_statement_free(statement);
+            BOOST_LOG_TRIVIAL(error)
+                << "Binding Cassandra book to doBookOffers query: " << rc
+                << ", " << cass_error_desc(rc);
+            return {};
+        }
         CassFuture* fut;
         do
         {