update the default limit (#646)

Fixes #648
This commit is contained in:
cyan317
2023-05-25 11:39:08 +01:00
committed by GitHub
parent c50174235f
commit 0bbb539d0b
5 changed files with 7 additions and 7 deletions

View File

@@ -76,7 +76,7 @@ public:
std::optional<std::string> destinationAccount; std::optional<std::string> destinationAccount;
std::optional<std::string> ledgerHash; std::optional<std::string> ledgerHash;
std::optional<uint32_t> ledgerIndex; std::optional<uint32_t> ledgerIndex;
uint32_t limit = 50; uint32_t limit = 200;
std::optional<std::string> marker; std::optional<std::string> marker;
}; };

View File

@@ -76,7 +76,7 @@ public:
std::optional<std::string> peer; std::optional<std::string> peer;
bool ignoreDefault = false; // TODO: document bool ignoreDefault = false; // TODO: document
// https://github.com/XRPLF/xrpl-dev-portal/issues/1839 // https://github.com/XRPLF/xrpl-dev-portal/issues/1839
uint32_t limit = 50; uint32_t limit = 200;
std::optional<std::string> marker; std::optional<std::string> marker;
}; };

View File

@@ -49,7 +49,7 @@ public:
{ {
std::optional<std::string> ledgerHash; std::optional<std::string> ledgerHash;
std::optional<uint32_t> ledgerIndex; std::optional<uint32_t> ledgerIndex;
uint32_t limit = 50; uint32_t limit = 60;
std::optional<ripple::AccountID> taker; std::optional<ripple::AccountID> taker;
ripple::Currency paysCurrency; ripple::Currency paysCurrency;
ripple::Currency getsCurrency; ripple::Currency getsCurrency;

View File

@@ -387,7 +387,7 @@ TEST_F(RPCAccountHandlerTest, DefaultParameterTest)
"ledger_hash":"4BC50C9B0D8515D3EAAE1E74B29A95804346C491EE1A95BF25E4AAB854A6A652", "ledger_hash":"4BC50C9B0D8515D3EAAE1E74B29A95804346C491EE1A95BF25E4AAB854A6A652",
"ledger_index":30, "ledger_index":30,
"validated":true, "validated":true,
"limit":50, "limit":200,
"channels":[ "channels":[
{ {
"channel_id":"E6DBAFC99223B42257915A63DFC6B0C032D4070F9A574B255AD97466726FC321", "channel_id":"E6DBAFC99223B42257915A63DFC6B0C032D4070F9A574B255AD97466726FC321",
@@ -613,7 +613,7 @@ TEST_F(RPCAccountHandlerTest, OptionalResponseField)
"ledger_hash":"4BC50C9B0D8515D3EAAE1E74B29A95804346C491EE1A95BF25E4AAB854A6A652", "ledger_hash":"4BC50C9B0D8515D3EAAE1E74B29A95804346C491EE1A95BF25E4AAB854A6A652",
"ledger_index":30, "ledger_index":30,
"validated":true, "validated":true,
"limit":50, "limit":200,
"channels":[ "channels":[
{ {
"channel_id":"E6DBAFC99223B42257915A63DFC6B0C032D4070F9A574B255AD97466726FC321", "channel_id":"E6DBAFC99223B42257915A63DFC6B0C032D4070F9A574B255AD97466726FC321",

View File

@@ -433,7 +433,7 @@ TEST_F(RPCAccountLinesHandlerTest, DefaultParameterTest)
"ledger_hash": "4BC50C9B0D8515D3EAAE1E74B29A95804346C491EE1A95BF25E4AAB854A6A652", "ledger_hash": "4BC50C9B0D8515D3EAAE1E74B29A95804346C491EE1A95BF25E4AAB854A6A652",
"ledger_index": 30, "ledger_index": 30,
"validated": true, "validated": true,
"limit": 50, "limit": 200,
"lines": [ "lines": [
{ {
"account": "rLEsXccBGNR3UPuPu2hUXPjziKC3qKSBun", "account": "rLEsXccBGNR3UPuPu2hUXPjziKC3qKSBun",
@@ -629,7 +629,7 @@ TEST_F(RPCAccountLinesHandlerTest, OptionalResponseField)
"ledger_hash": "4BC50C9B0D8515D3EAAE1E74B29A95804346C491EE1A95BF25E4AAB854A6A652", "ledger_hash": "4BC50C9B0D8515D3EAAE1E74B29A95804346C491EE1A95BF25E4AAB854A6A652",
"ledger_index": 30, "ledger_index": 30,
"validated": true, "validated": true,
"limit": 50, "limit": 200,
"lines": [ "lines": [
{ {
"account": "rLEsXccBGNR3UPuPu2hUXPjziKC3qKSBun", "account": "rLEsXccBGNR3UPuPu2hUXPjziKC3qKSBun",