From 00026ebf5a8cd23a2e6d81066e642b59a37b7112 Mon Sep 17 00:00:00 2001
From: Alex Kremer <akremer@ripple.com>
Date: Wed, 7 Aug 2024 15:22:21 +0100
Subject: [PATCH] fix: Use doxygen 1.12 (#1587)

Fixes #1431
---
 .githooks/check-docs | 26 ++++++++++++++++++++++++--
 .githooks/pre-commit |  3 +--
 docker/ci/dockerfile |  2 +-
 3 files changed, 26 insertions(+), 5 deletions(-)

diff --git a/.githooks/check-docs b/.githooks/check-docs
index 7a475d09..14f9c9ac 100755
--- a/.githooks/check-docs
+++ b/.githooks/check-docs
@@ -13,14 +13,36 @@ TMPDIR=${ROOT}/.cache/doxygen
 TMPFILE=${TMPDIR}/docs.log
 DOCDIR=${TMPDIR}/out
 
+# Check doxygen is at all installed
 if [ -z "$DOXYGEN" ]; then
     # No hard error if doxygen is not installed yet
     cat <<EOF
 
                                    WARNING
 -----------------------------------------------------------------------------
-        'doxygen' is required to check documentation.
-        Please install it for next time. For the time being it's on CI.
+        'doxygen' is required to check documentation. 
+        Please install it for next time.
+
+        Your changes may fail to pass CI once pushed.
+-----------------------------------------------------------------------------
+
+EOF
+    exit 0
+fi
+
+# Check version of doxygen is at least 1.12
+version=$($DOXYGEN --version | grep -o '[0-9\.]*')
+
+if [[ "1.12.0" > "$version" ]]; then
+    # No hard error if doxygen version is not the one we want - let CI deal with it
+    cat <<EOF
+
+                                    ERROR
+-----------------------------------------------------------------------------
+        A minimum of version 1.12 of `which doxygen` is required.
+        Your version is $version. Please upgrade it for next time.
+
+        Your changes may fail to pass CI once pushed.
 -----------------------------------------------------------------------------
 
 EOF
diff --git a/.githooks/pre-commit b/.githooks/pre-commit
index 46a5915a..241ff9ae 100755
--- a/.githooks/pre-commit
+++ b/.githooks/pre-commit
@@ -3,6 +3,5 @@
 # This script is intended to be run from the root of the repository.
 
 source .githooks/check-format
-#source .githooks/check-docs
+source .githooks/check-docs
 
-# TODO: Fix Doxygen issue with reference links. See https://github.com/XRPLF/clio/issues/1431
diff --git a/docker/ci/dockerfile b/docker/ci/dockerfile
index 2099713e..60c9fc22 100644
--- a/docker/ci/dockerfile
+++ b/docker/ci/dockerfile
@@ -9,7 +9,7 @@ WORKDIR /root
 ENV CCACHE_VERSION=4.10.2 \
     LLVM_TOOLS_VERSION=18 \
     GH_VERSION=2.40.0 \
-    DOXYGEN_VERSION=1.10.0
+    DOXYGEN_VERSION=1.12.0
  
 # Add repositories
 RUN apt-get -qq update \